Opened 10 years ago

Closed 7 years ago

#18985 closed defect (fixed)

easytag-devel 2.1.6 lacks a dependency on libid3tag

Reported by: breitreifen@… Owned by: bytestorm@…
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: haspatch Cc: ozaktash@…, ryandesign (Ryan Schmidt), neukomp@…
Port: easytag-devel

Description

A common port install for easytag-devel may look like this:

$ port install easytag-devel +ogg +mp4 +mp3

This didn't work for me. EasyTAG did not recognize any mp3 file. Dialog Help->About showed something like "MP3 ... disabled".

When debug is switched on, console output shows, that variant '+mp3' is recognized (at least it tries to build MP3 support), but configure doesn't find some header file:


checking for MP3 file support... checking id3tag.h usability... no
checking id3tag.h presence... no
checking for id3tag.h... no
checking for id3_frame_field in -lid3tag... no
no
***
*** Warning: MP3 file support disabled, libid3tag missing
***


Configure ends up with:


Configuration for easytag 2.1.6 :
--------------------------------

Source code location ....: .
Host System Type ........: i386-apple-darwin9.6.0
Preprocessor ............: /usr/bin/gcc-4.0 -I/opt/local/include
Compiler ................: /usr/bin/gcc-4.0 -O2 -Wall
Linker ..................: /usr/bin/gcc-4.0 -L/opt/local/lib -lmp4v2 -lm -lz -lstdc++ -lid3 -lvorbisfile -lvorbis -logg -lm
GTK2 version ............: 2.14.7
MP3 file support ........: no
ID3v2.3 tags support ....: yes (id3lib-3.8.3)
Ogg Vorbis file support .: yes
Speex file support ......: no
FLAC file support .......: no
MP4 file support ........: yes
WavPack support .........: no
NLS/gettext .............: yes
Install path ............: /opt/local


Please note: "MP3 file support ........: no"

After install of required libid3tag ...

$ port install libid3tag

... configure ends up with:


Configuration for easytag 2.1.6 :
--------------------------------

Source code location ....: .
Host System Type ........: i386-apple-darwin9.6.0
Preprocessor ............: /usr/bin/gcc-4.0 -I/opt/local/include
Compiler ................: /usr/bin/gcc-4.0 -O2 -Wall
Linker ..................: /usr/bin/gcc-4.0 -L/opt/local/lib -lmp4v2 -lm -lz -lstdc++ -lid3 -lid3tag -lvorbisfile -lvorbis -logg -lm
GTK2 version ............: 2.14.7
MP3 file support ........: yes
ID3v2.3 tags support ....: yes (id3lib-3.8.3)
Ogg Vorbis file support .: yes
Speex file support ......: no
FLAC file support .......: no
MP4 file support ........: yes
WavPack support .........: no
NLS/gettext .............: yes
Install path ............: /opt/local


Please note "MP3 file support ........: yes".

As expected, EasyTAG runs fine now and is able to handle MP3-Files. Dialog Help->About shows "MP3 ... enabled".

From Portfile:


variant mp3 {		configure.args-delete	--disable-mp3
			depends_lib-append	port:id3lib
			}


I'm no special expert in MP3 tagging libs but it seems, id3lib is just for support of Version 2.3 for ID3-tags, while libid3tag provides basic tagging functionality that is required for EasyTAG.

Attachments (2)

easytag-devel-mp4v2.patch (927 bytes) - added by ozaktash@… 9 years ago.
Portfile (2.0 KB) - added by ozaktash@… 9 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by breitreifen@…

I'm sorry, I've made a typo in the version number.

This ticket relates to "2.1.6" of course, not to "2.1.16", which eventually will never exist.

comment:2 Changed 10 years ago by raimue (Rainer Müller)

Cc: bytestorm@… added
Summary: Portfile for EasyTAG 2.1.16 lacks a dependency on libid3tagPortfile for EasyTAG 2.1.6 lacks a dependency on libid3tag

comment:3 Changed 10 years ago by dbevans (David B. Evans)

Cc: bytestorm@… removed
Owner: changed from macports-tickets@… to bytestorm@…

comment:4 Changed 10 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Changed 9 years ago by ozaktash@…

Attachment: easytag-devel-mp4v2.patch added

Changed 9 years ago by ozaktash@…

Attachment: Portfile added

comment:5 Changed 9 years ago by ozaktash@…

I have modified the portile to add id3lib dependency.

There was also a problem with mp4 file support, the source should be patched for mp4v2 support. So I have added patchfiles easytag-devel-mp4v2.patch instruction in the portfile too. Since the original patchfile was written for stable easytag (2.1), I had to slightly modify it so suit easytag-devel. I have uploaded the modified patchfile too. Since the patch file is not on the net, I set patch_sites to ${filespath}.

I hope this will help.

I am a newbie, so any correction is welcome

comment:6 in reply to:  5 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: ozaktash@… ryandesign@… neukomp@… added
Keywords: haspatch added
Resolution: fixed
Status: newclosed
Summary: Portfile for EasyTAG 2.1.6 lacks a dependency on libid3tageasytag-devel 2.1.6 lacks a dependency on libid3tag

Thanks. Committed in r87428.

When the patch is in the files directory, there is no need to use patch_sites.

When submitting a change to an existing portfile, please supply a unified diff of the portfile, not a complete new portfile.

Has duplicate #32169.

Note: See TracTickets for help on using tickets.