Opened 10 years ago

Closed 10 years ago

#19325 closed enhancement (fixed)

vlc: remove aqua variant

Reported by: ryandesign (Ryan Schmidt) Owned by: max@…
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: Cc: nerdling (Jeremy L)
Port: vlc

Description

Could the +aqua variant of the vlc port be removed? Just make what the variant does happen always on platform macosx. Having fewer variants is better.

Attachments (1)

VLC-Portfile.diff (1.1 KB) - added by max@… 10 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by max@…

What the +aqua variant does is create VLC.app and install it in ${applications_dir}. Without this variant there will be just a vlc executable in ${prefix}/bin. I think moving this to platform macosx wouldn't be appropriate. I could remove the variant at all if you feel it is unnecessary and always create/install VLC.app or rename it to something different

comment:2 in reply to:  1 ; Changed 10 years ago by ryandesign (Ryan Schmidt)

Replying to max@…:

What the +aqua variant does is create VLC.app and install it in ${applications_dir}.

That's what I thought.

Without this variant there will be just a vlc executable in ${prefix}/bin.

Yes, I didn't mean you should remove this functionality.

I think moving this to platform macosx wouldn't be appropriate. I could remove the variant at all if you feel it is unnecessary and always create/install VLC.app or rename it to something different

My issue is not with the name of the variant, my issue is with there being a variant for this at all. Why would anyone want to turn it off? Just do it all the time, on Mac OS X.

My reason for suggesting doing this in the "platform macosx" section is so that it does not impact users installing vlc on other operating systems. However, I see the portfile already has other things in it that are Mac OS X-specific. I also see now that the "destroot.target" line already contains "install VLC.app" always. The aqua variant does nothing but append "VLC.app" to "destroot.target" again, so it's completely ineffective anyway. So you could either move all of the Mac OS X-specific stuff to the "platform macosx" section, or you could decide that the vlc port will only work on Mac OS X. In the latter case, you can simply remove the aqua variant, and also change the "platforms" line from "darwin" to "macosx".

comment:3 in reply to:  2 Changed 10 years ago by max@…

Ok i moved the the functionality of +aqua into macosx and removed the standard destroot.target VLC.app

Changed 10 years ago by max@…

Attachment: VLC-Portfile.diff added

comment:4 Changed 10 years ago by (none)

Milestone: Port Enhancements

Milestone Port Enhancements deleted

comment:5 Changed 10 years ago by ryandesign (Ryan Schmidt)

Cc: snc@… added
Resolution: fixed
Status: newclosed

The patch was partially applied in r53864 with the update to 1.0.0_0; the part that wasn't committed prevented VLC.app from being installed. I committed the last bit in r53998 and bumped the revision to 1.0.0_1 so everyone will again have VLC.app.

Note: See TracTickets for help on using tickets.