Opened 10 years ago

Closed 10 years ago

#19386 closed defect (fixed)

rtmpdump: libkern/_OSByteOrder.h: No such file or directory

Reported by: ryandesign (Ryan Schmidt) Owned by: CaptSolo
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: Cc:
Port: rtmpdump

Description

I'm unable to build rtmpdump 1.4 on Mac OS X 10.4.11 Intel with Xcode 2.5 and MacPorts 1.7.1.

$ port install rtmpdump
--->  Fetching rtmpdump
--->  Attempting to fetch rtmpdump-v1.4.tar.gz from http://distfiles.macports.org/rtmpdump
--->  Verifying checksum(s) for rtmpdump
--->  Extracting rtmpdump
--->  Applying patches to rtmpdump
--->  Configuring rtmpdump
--->  Building rtmpdump
Error: Target org.macports.build returned: shell command " cd "/mp/var/macports/build/_Users_rschmidt_macports_dports_www_rtmpdump/work/rtmpdump" && nice -n 10 make all " returned error 2
Command output: g++ -Wall   -c -o bytes.o bytes.cpp
In file included from bytes.cpp:25:
bytes.h:39:35: error: libkern/_OSByteOrder.h: No such file or directory
bytes.cpp: In function 'void WriteNumber(char*, double)':
bytes.cpp:37: error: '__DARWIN_OSSwapConstInt64' was not declared in this scope
bytes.cpp: In function 'double ReadNumber(const char*)':
bytes.cpp:66: error: '__DARWIN_OSSwapConstInt64' was not declared in this scope
make: *** [bytes.o] Error 1

Error: Status 1 encountered during processing.

I have /usr/include/libkern/OSByteOrder.h but no _OSByteOrder.h anywhere.

No problem on another Mac with Mac OS X 10.5.6 and Xcode 3.1.2 where /usr/include/libkern/_OSByteOrder.h does exist.

Attachments (4)

patch-bytes.h.diff (736 bytes) - added by CaptSolo 10 years ago.
patch-bytes.cpp.diff (355 bytes) - added by vike2000 10 years ago.
from sourceforge.net/forum/message.php?msg_id=7267196, for functional downloading on os 10.4
patch-bytes.h.2.diff (727 bytes) - added by vike2000 10 years ago.
supposed to work on both os 10.4 and .5. see sourceforge.net/forum/forum.php?thread_id=3137807&forum_id=900998
Portfile-rtmpdump.diff (653 bytes) - added by CaptSolo 10 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by CaptSolo

A fixed patch is described at: https://sourceforge.net/forum/forum.php?thread_id=3137807&forum_id=900998

Could you test if it works for you (as I do not have 10.4 to test on)?

Changed 10 years ago by CaptSolo

Attachment: patch-bytes.h.diff added

comment:2 Changed 10 years ago by CaptSolo

Attached the new patch.

comment:3 Changed 10 years ago by vike2000

'installed' the attached patch and it built fine on os10.4.11 (newly installed macports (for this port - as a first on this machine) said "not outdated" for "selfupdate" and yet i had to put the attachment in place, so the port is not updated yet?)

comment:4 Changed 10 years ago by CaptSolo

Thanks a lot for checking this!

No, the patch has not been implemented in port repository yet. Needed someone with 10.4 to check it first. The port can be updated with the patch now.

P.S. Regarding "not outdated" that was probably a message about macports itself. It could not have known about this patch for a port because it is just an attachment to a ticket.

comment:5 Changed 10 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Changed 10 years ago by vike2000

Attachment: patch-bytes.cpp.diff added

from sourceforge.net/forum/message.php?msg_id=7267196, for functional downloading on os 10.4

Changed 10 years ago by vike2000

Attachment: patch-bytes.h.2.diff added

supposed to work on both os 10.4 and .5. see sourceforge.net/forum/forum.php?thread_id=3137807&forum_id=900998

comment:6 Changed 10 years ago by vike2000

glad if i can help out. weve all got our reasons, humble or not, they may be. use the force ;]

but okay, ive flooded the sourceforge thread and finally got v 1.4 working for me. as i say there, it was yasuda1963's patch that was crucial for any data to download at os 10.4.11, ppc g5 i attached my patches to the ticket.. ok to add the one for bytes.cpp to this ticket - as it relates to building for tiger (dont know how strict you are with the tickets)? and then the one for the header, as it seems the one in the /browser/trunk/dports is still the older - non-working on os 10.4..

thank you

ps. i tried to build v1.5 as well. see sourceforge.net/forum/message.php?msg_id=7320112 for my puny results.. if you feel like looking in to it, would you like to see me wait a while to upgrade to os10.5? my needs seems to be filled for now with v1.4 and im in no rush to up the os (and would frankly be pleased to be able to blame the delay to upgrade on this instead of my own laziness :) - you know, upgrading is a hazzle if you want everything right)..

signing out, peace, good night /vike

Changed 10 years ago by CaptSolo

Attachment: Portfile-rtmpdump.diff added

comment:7 Changed 10 years ago by CaptSolo

Attached a patch for the Portfile.

This patch applies the two patches attached by vike2000 (patch-bytes.h.2.diff and patch-bytes.cpp.diff) and fixes this bug.

Could someone with commit rights apply these patches?

comment:8 Changed 10 years ago by CaptSolo

note1: patch-bytes.h.2.diff should replace patch.bytes.h that the current version of the port has.

note2: the current version of the port also has a patch-log.h.diff patch. that should remain, but I was not sure if it needs to be added to this ticket again (probably not?).

comment:9 Changed 10 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: newclosed

Committed in r50620 with small changes:

  • First revision is 0, so this should be revision 1
  • Keep patch file name clean
Note: See TracTickets for help on using tickets.