Opened 12 years ago

Closed 11 years ago

#19485 closed submission (fixed)

AntTweakBar Portfile addition

Reported by: karcaw@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: Cc:
Port: AntTweakBar

Description

Here is a port file for the AntTweakBar from here: http://www.antisphere.com/Wiki/tools:anttweakbar I have talked with Phillipe, and he is fine with me adding a port file, and maintaining it for him. I have built it in the graphics section for my testing.

Attachments (2)

Portfile (1.4 KB) - added by karcaw@… 11 years ago.
ATB_113_mac.patch (2.1 KB) - added by karcaw@… 11 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by jmroot (Joshua Root)

Some things that should be changed:

  • Setting distfiles explicitly is discouraged, as is hardcoding the name, version and extract.suffix in it. Try this instead:
    distname           ${name}_[join [split ${version} .] ""]
    
    That way, distfiles will automatically stay correct when version is changed.
  • patch.pre_args defaults to -p0, so there's no need to set it to that.
  • Instead of making a link to the extracted directory, just set worksrcdir like this:
    worksrcdir          ${name}
    
  • The build system compiles with 'gcc'. This could point to any gcc version, so for consistency, it should be made to use the value of ${configure.cc} instead.
  • It also passes -I/usr/local/include -I/usr/X11R6/include to the compiler. Ports should not normally use anything from these locations, and problems can result if conflicting headers are installed there.
  • Regarding the patch, $(PREFIX) starts with a slash, so $(DESTDIR)/$(PREFIX) ends up having a double slash.

Changed 11 years ago by karcaw@…

Attachment: Portfile added

Changed 11 years ago by karcaw@…

Attachment: ATB_113_mac.patch added

comment:2 Changed 11 years ago by karcaw@…

I have addresses the changes you suggested. Please re-review and evaluate for acceptance.

comment:3 Changed 11 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Port: AntTweakBar added
Status: newassigned

comment:4 Changed 11 years ago by blb@…

Resolution: fixed
Status: assignedclosed

Added in r59854, thanks.

Note: See TracTickets for help on using tickets.