PolicyKit 0.9 + Mac OS 10.6 10A394

[lowell@…]

Hey everyone! Freshly registered, first-time poster here. I found an issue with PolicyKit on my system that I wasn't able to find with the search utility on the issue tracker.

It expects a header, pam_appl.h, to be located at /usr/include/pam; a quick glance over some Google results reveals the file has been at that location for Mac OS' previous couple of iterations.

However, in the 10.6 Developer Preview, it's been moved back to /usr/include/security/; this borks a very specific reference:

#ifdef POLKIT_AUTHFW_PAM
#ifdef __APPLE__
#include <pam/pam_appl.h>
#else
#include <security/pam_appl.h>
#endif
#endif

The three affected files are:

PolicyKit-0.9/src/polkit-dbus/polkit-resolve-exe-helper.c

PolicyKit-0.9/src/polkit-grant/polkit-grant-helper-pam.c

PolicyKit-0.9/src/polkit-grant/polkit-grant-helper.c

Here's some bash output:

#before..
[sierra117::/] $ sudo port install policykit
--->  Computing dependencies for policykit
--->  Building policykit
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_security_policykit/work/PolicyKit-0.9" && /usr/bin/make -j1 all " returned error 2
Command output: /usr/bin/make  all-recursive
Making all in data
make[2]: Nothing to be done for `all'.
Making all in src
Making all in kit
make[3]: Nothing to be done for `all'.
Making all in polkit
make[3]: Nothing to be done for `all'.
Making all in polkit-dbus
/usr/bin/gcc-4.2 -DHAVE_CONFIG_H -I. -I../.. -I../../src -I../../src -DPACKAGE_LIBEXEC_DIR=\""/opt/local/libexec"\" -DPACKAGE_SYSCONF_DIR=\""/opt/local/etc"\" -DPACKAGE_DATA_DIR=\""/opt/local/share"\" -DPACKAGE_BIN_DIR=\""/opt/local/bin"\" -DPACKAGE_LOCALSTATE_DIR=\""/opt/local/var"\" -DPACKAGE_LOCALE_DIR=\""/opt/local/share/locale"\" -DPACKAGE_LIB_DIR=\""/opt/local/lib"\" -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT -DPOLKIT_COMPILATION -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include    -I/opt/local/include -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include   -O2 -Wall -Wchar-subscripts -Wmissing-declarations -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -Wformat -Wformat-security -MT polkit_resolve_exe_helper-polkit-resolve-exe-helper.o -MD -MP -MF .deps/polkit_resolve_exe_helper-polkit-resolve-exe-helper.Tpo -c -o polkit_resolve_exe_helper-polkit-resolve-exe-helper.o `test -f 'polkit-resolve-exe-helper.c' || echo './'`polkit-resolve-exe-helper.c
polkit-resolve-exe-helper.c:47:26: error: pam/pam_appl.h: No such file or directory
make[3]: *** [polkit_resolve_exe_helper-polkit-resolve-exe-helper.o] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Error: Status 1 encountered during processing.

# and after..
[sierra117::/] $ sudo port install policykit
--->  Computing dependencies for policykit
--->  Building policykit
--->  Staging policykit into destroot
--->  Installing policykit @0.9_0
--->  Activating policykit @0.9_0
--->  Cleaning policykit

Just letting you all know just in case this wasn't an isolated incident. I'm pretty sure it isn't; I don't knowingly move files around in /usr.

[lowell@…]

Cc Me!

[lowell@…]

Oops! Title should read: PolicyKit 0.9 + Mac OS 10.6 10A394.

[dbevans (David B. Evans)]

Thanks for this information. Will take a look and ask you to test any particular remedy on your system before committing any changes.

Have removed you from CC as the ticket reporter is automatically copied.

[tobypeterson]

r53174

[tobypeterson]

Note: didn't actually test, as I do not feel like compiling gnome. However, it's a pretty minor change. :-)