Opened 10 years ago

Closed 10 years ago

#20198 closed update (fixed)

Update: eggdrop1.6.19+ctcpfix

Reported by: dreness (Andre LaBranche) Owned by: nerdling (Jeremy L)
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: Cc:
Port: eggdrop

Description (last modified by mf2k (Frank Schima))

I've completed testing of an update to the irc/eggdrop port, and am ready to submit. The current macports version of eggdrop is 1.6.18. Since then, there has been a minor version release and a security patch. The patched version of 1.6.19 is called eggdrop1.6.19+ctcpfix, however the source directory still unpacks as eggdrop1.6.19.

To handle the 'custom' name for this build:

  • I have customized the distname to include the "+ctcpfix" string:
    ${name}${version}+ctcpfix
    
  • I added a worksrcdir declaration with value:
    ${name}${version}
    

Accordingly, the version string can stay at "eggdrop1.6.19" - this avoids problems where the + is interpreted by 'port' as the beginning of a variant declaration.

The platform handling has not changed for any existing supported platforms, however I am adding explicit support for Snow Leopard (Mac OS X 10.6) via an additional patch to Makefile.in. Attempts to pass the required settings through the Portfile will fail in 10.6, at least as of this writing... hence the need to patch Makefile.in. The patch occurs pre-configure, and allows us to end up with a Makefile whose XLIBS contains:

-framework CoreFoundation -lresolv

I've tested this in the following configurations:

  • Mac OS X Server 10.6 running as VMWare Fusion guest on MacPro1,1 (compiled x86_64)
  • 10.5.7 on MacPro1,1
  • 10.6 on MacBookPro5,1
  • 10.5.7 on MacPro3,1

Attachments (2)

Portfile-eggdrop-1.6.19-ctcpfix.diff (1.1 KB) - added by dreness (Andre LaBranche) 10 years ago.
Portfile patch
patch-Makefile.in.diff (426 bytes) - added by dreness (Andre LaBranche) 10 years ago.
Makefile.in patch (goes in irc/eggdrop/files)

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by dreness (Andre LaBranche)

Portfile patch

Changed 10 years ago by dreness (Andre LaBranche)

Attachment: patch-Makefile.in.diff added

Makefile.in patch (goes in irc/eggdrop/files)

comment:1 Changed 10 years ago by mf2k (Frank Schima)

Cc: dre@… removed
Description: modified (diff)

comment:2 Changed 10 years ago by nerdling (Jeremy L)

Owner: changed from macports-tickets@… to snc@…
Status: newassigned

comment:3 Changed 10 years ago by nerdling (Jeremy L)

Resolution: fixed
Status: assignedclosed

Committed in r53479.

Confirmed, works for darwin 10 (client).

Note: See TracTickets for help on using tickets.