Opened 11 years ago

Closed 7 years ago

#20855 closed defect (fixed)

orpie: won't link on build - patch included

Reported by: jcdenton513@… Owned by: snb@…
Priority: Normal Milestone:
Component: ports Version: 1.8.0
Keywords: haspatch Cc: christopher.andrey@…, brett@…
Port: orpie

Description

This isn't the most elegant fix I'm sure, but it works and I've successfully linked and ran the application.

As far as I can see, it's looking for libmlgsl.a which is provided by the package ocamlgsl. The orpie source file has that library but it doesn't seem to link correctly. My solution while creating more dependencies, works very well. It'd require ocamlgsl and because it modifies configure.in, it'll need autoconf to build a new configure file.

Once the patch is applied, the program will compile and link and will be ready to install.

Attachments (3)

orpie.patch.gz (727 bytes) - added by jcdenton513@… 11 years ago.
Makefile.in.diff (541 bytes) - added by snb@… 11 years ago.
orpie.patch (695 bytes) - added by jcdenton513@… 11 years ago.
doesn't require autoconf

Download all attachments as: .zip

Change History (14)

Changed 11 years ago by jcdenton513@…

Attachment: orpie.patch.gz added

comment:1 Changed 11 years ago by jcdenton513@…

Cc: jcdenton513@… added

Cc Me!

comment:2 Changed 11 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to snb@…

Assigning to maintainer for comment.

comment:3 Changed 11 years ago by brett@…

tested here too, looks good

Changed 11 years ago by snb@…

Attachment: Makefile.in.diff added

comment:4 Changed 11 years ago by snb@…

The patch I just attached, Makefile.in.diff, will force use of ocamlc instead of ocamlc.opt. I'm not sure why, but this also seems to fix the problem for me and doesn't require adding more dependencies or autoconf. Less dependencies seems nice, but I think my fix also isn't necessarily the most elegant :) Either my patch or the reporter's is fine by me to commit.

I should mention that I haven't been using MacPorts lately, so if someone else wants to be maintainer of this port, be my guest.

Changed 11 years ago by jcdenton513@…

Attachment: orpie.patch added

doesn't require autoconf

comment:5 Changed 11 years ago by jcdenton513@…

You're solution worked for me.

Concerning my solution, you could drop the modifying the configure file and just insert the variables directly to Makefile.in. The main reason I went the route I did was so if you ran ./configure it'd notice if libmlgsl.a was or wasn't avaliable. Being managed by a MacPorts, it would already know if the dependency was avaliable so checking with configure would be redundant and that step can be left out.

I attached another patch that'll do just that, getting rid of the autoconf requirement.

Whether you use my patch or the other I guess depends on if you want it to use an external library or the static library in orpie's source. The only advantage I can see with my way is if ocamlgsl is updated, orpie will benifit. Unless that upgrade breaks orpie. Both look like they're not actively maintained so it probably wouldn't matter either way. Can't be positive about ocamlgsl though.

comment:6 Changed 11 years ago by mf2k (Frank Schima)

Cc: macsforever2000@… added

Cc Me!

comment:7 Changed 11 years ago by christopher.andrey@…

Cc: christopher.andrey@… added

Cc Me!

comment:8 Changed 10 years ago by jmroot (Joshua Root)

Cc: jcdenton513@… removed
Keywords: haspatch added; orpie link build removed

comment:9 Changed 10 years ago by jmroot (Joshua Root)

Cc: brett@… added

So which of these patches should be committed? And are there any portfile changes needed beyond adding patchfiles? Brett, you seem to have figured this out in comment:3.

comment:10 Changed 10 years ago by snb@…

As far as I can tell, jcdenton513's patches would require adding a dependency on ocamlgsl to the Portfile. My patch should not necessitate that as it should make orpie use its own version of ocamlgsl. Otherwise just adding patchfiles should be sufficient. It does not matter to me what patch is used, though, and I don't know if any of them actually still work (I don't have a macports installation around to test at the moment).

comment:11 Changed 7 years ago by mf2k (Frank Schima)

Cc: macsforever2000@… removed
Resolution: fixed
Status: newclosed

This seems to be working as is now. The patch by snb was added sometime in the past.

$ port -d installed orpie
The following ports are currently installed:
  orpie @1.5.1_2 (active) platform='darwin 13' archs='x86_64'
Note: See TracTickets for help on using tickets.