icedtea 1.11 Proposed Port

[mvfranz@…]

Hi,

I have a Portfile that works for building IcedTea 1.11 On intel for Leopard and Snow Leopard. I would like this to be included. People more familiar with Macports should review and comment as there is lots of things going on to get this to work.

This allows OpenJDK 7 to be built using ecj and Apple's 1.5 JDK. Currently only Intel is supported, but there is Zero and Shark that work for PPC (just not BSD).

I do not have access to a PowerPC Mac to test.

[mvfranz@…]

Patches to IcedTea's configure script

[mvfranz@…]

Changes to IcedTea Makefile.am

[ryandesign (Ryan Carsten Schmidt)]

My notes so far:

• "/opt/local" is hardcoded in some files; you must arrange to use ${prefix} instead, for example by putting "@PREFIX@ in those files and then using reinplace in the portfile
• why are you making a tmp directory in /var/tmp? ${workpath} is a port's temporary work area; can't you make a directory in there?
• in the configure.args, the number of parallel jobs should be taken from the variable ${build.jobs} which is based on the setting build_make_jobs in macports.conf
• in the destroot phase, why use tar to copy files? Can't use use the tcl "file copy" procedure?
• patchfile patch-openjdk-hotspot-src-share-vm-utilities-globalDefinitions.hpp.diff is referenced by the port but missing from this ticket

[mvfranz@…]

Replying to ryandesign@…: All great points.

My notes so far:

• "/opt/local" is hardcoded in some files; you must arrange to use ${prefix} instead, for example by putting "@PREFIX@ in those files and then using reinplace in the portfile

I will change the hard coded values of /opt/local.

• why are you making a tmp directory in /var/tmp? ${workpath} is a port's temporary work area; can't you make a directory in there?

I can change the temp directory without a problem

• in the configure.args, the number of parallel jobs should be taken from the variable ${build.jobs} which is based on the setting build_make_jobs in macports.conf

I will use the ${build.jobs} variable. I had copied some of this from the openjdk6 port.

• in the destroot phase, why use tar to copy files? Can't use use the tcl "file copy" procedure?

This I copied from the openjdk6 port. It worked there, so I did the easiest thing. Let me try to figure out a tcl based implementation.

• patchfile patch-openjdk-hotspot-src-share-vm-utilities-globalDefinitions.hpp.diff is referenced by the port but missing from this ticket

I attached the missing file.

I'll upload a new Portfile when I have something working.

[ryandesign (Ryan Carsten Schmidt)]

Replying to mvfranz@…:

I will use the ${build.jobs} variable. I had copied some of this from the openjdk6 port.

Ah, ok. We should change openjdk6 too then.

• in the destroot phase, why use tar to copy files? Can't use use the tcl "file copy" procedure?

This I copied from the openjdk6 port. It worked there, so I did the easiest thing. Let me try to figure out a tcl based implementation.

I would think it would just be something like

file copy ${worksrcpath}/openjdk/build/bsd-i586/j2sdk-image ${destroot}${prefix}/share/java/${name}

[mvfranz@…]

special script to run ecj

[mvfranz@…]

I have attached ecj.in and patch-openjdk-hotspot-src-os-bsd-vm-os_bsd.cpp.diff that use the @@PREFIX@@ that are replaced in the Portfile. I also uploaded a new version of the Porfile.

I was not able to figure out how to use copy and move to replace the use of tar to preform the install. The copy works, but the rename seems to be ignored.

[mvfranz@…]

To get this work on Snow Leopard the following changes are required in the Portfile.

build.args CC=gcc-4.0 CXX=g++-4.0 \

configure.compiler  gcc-4.0

It seems that the default Snow Leopard compiler will not work for compiling the OpenJDK.

[mvfranz@…]

Portfile with proper install script

[kiniry@…]

Cc Me!

[petrrr]

Cc Me!

[kencu (Ken)]

this ancient portfile is terribly out of date now. Any objections to closing this?

[JacksonIsaac (Jackson Isaac)]

Instead of closing this can we try getting this into macports ?

I am giving it a try but not sure how easy or complex it would be.

[pmetzger (Perry E. Metzger)]

JacksonIsaac: nothing is stopping you from doing the work. I think, however, that we can close this.