Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#21619 closed defect (fixed)

irssi references wrong path for docs and in man pages

Reported by: scott@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.8.0
Keywords: Cc:
Port: irssi irssi-devel

Description

port contents irssi puts most files in /opt/local/share/irssi/ irssi works well with a port install command, and needs no altering to be able to get on irc, though I am finding some areas that I believe could use improving.

One of the settings in the ~/.irssi/config, is: help_path = /usr/local/share/irssi/help

This path is set by default, I believe internally, to /usr/local/share/irssi/help, I am not sure if that can be changed with a configure arg, though it should be set to /opt/local/share/irssi/help

Not sure how to deal with that if it can not be set as a configure argument.

man irssi shares the same issues, reference to paths that are outside of {prefix}

What is the suggested way to solve these? I am willing to see what I can do to the port file to make it work out better, but in this case, I am not sure how to go about this, other than ui messages that tell the user to issue /set.

Change History (10)

comment:1 Changed 10 years ago by scott@…

Cc: scott@… added

Cc Me!

comment:2 Changed 10 years ago by tobypeterson

Cc: scott@… removed
Keywords: irssi removed
Summary: irssi port path for docs and man pagesirssi references wrong path for docs and in man pages
Type: enhancementdefect

comment:3 Changed 10 years ago by blb@…

If you run /set help_path while in irssi, it shows the /usr/local path? Granted, I'm using irssi-devel and not irssi, but without a help_path setting in .irssi/config, /set help_path does show the proper location.

As far as the man page, that's fixed in r58329.

comment:4 in reply to:  3 ; Changed 10 years ago by scott@…

Replying to blb@…:

If you run /set help_path while in irssi, it shows the /usr/local path? Granted, I'm using irssi-devel and not irssi, but without a help_path setting in .irssi/config, /set help_path does show the proper location.

As far as the man page, that's fixed in r58329.

$cd ~/.irssi
$cp config config.bk
$rm config

I should now have a default install, run irssi and /connect help_path = /opt/local/share/irssi/help

So when you say shows the proper location, I assume you mean a {prefix}'d one? That is not what I am seeing, as shown above. Simple fix, was to set it correct, but I believe we should be able to set this for the user, so the help files are workable.

I believe this just needs to have help_path = "/opt/local/share/irssi/help"; set in irssi.conf in the root of the source files. Not 100% sure, I am looking at ./configure -help and see there is:

--with-tags[=TAGS] include additional configurations [automatic]

That may be how you change the defaults, the INSTALL file does not mention that arg, and the source is deeper than I can grok.

comment:5 Changed 10 years ago by scott@…

I can not edit my own posts? Can someone wiki format the shell commands and then delete this post? Thank you.

comment:6 in reply to:  4 ; Changed 10 years ago by blb@…

Port: irssi-devel added

Replying to scott@…:

I should now have a default install, run irssi and /connect help_path = /opt/local/share/irssi/help

So when you say shows the proper location, I assume you mean a {prefix}'d one? That is not what I am seeing, as shown above. Simple fix, was to set it correct, but I believe we should be able to set this for the user, so the help files are workable.

Right, the one with ${prefix} in it; isn't /opt/local/share/irssi/help the right one then (since /opt/local is usually ${prefix})?

Hmm, maybe I'm misunderstanding; did your .irssi/config file get set up automatically with a setting for help_path which was wrong? It looks like, without it being set at all, your help_path is set right otherwise.

comment:7 in reply to:  6 ; Changed 10 years ago by scott@…

Hmm, maybe I'm misunderstanding; did your .irssi/config file get set up automatically with a setting for help_path which was wrong? It looks like, without it being set at all, your help_path is set right otherwise.

I can not replicate it. When I ran /set help_path the other day, it repeatedly returned /usr/local/share/irssi/help. What I pasted above I did not even look at, and just pasted, as I assumed it was of course, still wrong. Sorry.

I looked through my irc logs where I was talking to a friend about this, and I remember copying and pasting the paths, and those logs have /usr/local/share/irssi/help. I also was getting no help data returned, since there were no files in that location.

If a mv config config.bk, then I /connect and run /set foo and then /save the help_path is not set in the config file, but the default is correct, using /opt/local/share/irssi/help

I can conclude, that things work as they should, but there is one edge case, which I can not replicate, where that path may be wrong. Thanks for the link to the change for the man page, that should conclude this ticket as resolved until I can figure out what this edge case is.

What is in the devel that you run it? I gave it a shot that is a very long build, I finally abandoned it. Thank you for looking into this, I think we can close this up as user error at this point, since the man page issue is solved.

comment:8 in reply to:  7 ; Changed 10 years ago by blb@…

Resolution: fixed
Status: newclosed

Replying to scott@…:

I can conclude, that things work as they should, but there is one edge case, which I can not replicate, where that path may be wrong. Thanks for the link to the change for the man page, that should conclude this ticket as resolved until I can figure out what this edge case is.

If you find the source of that, say so; make sure you don't simply have another irssi (eg, /usr/local/bin/irssi) that could be confusing things.

What is in the devel that you run it? I gave it a shot that is a very long build, I finally abandoned it. Thank you for looking into this, I think we can close this up as user error at this point, since the man page issue is solved.

The irssi-devel port is simply irssi but tracking what's going on in the project's subversion repository instead of the releases like the irssi port. The only difference between it and irssi for dependencies would be that it doesn't have +perl and instead always builds for perl support. If it was going slowly, it could be their slow subversion server, which I've seen on more than one occasion.

comment:9 in reply to:  8 Changed 10 years ago by scott@…

What is in the devel that you run it? I gave it a shot that is a very long build, I finally abandoned it. Thank you for looking into this, I think

we can close this up as user error at this point, since the man page issue is solved.

The irssi-devel port is simply irssi but tracking what's going on in the project's subversion repository instead of the releases like the irssi port. The only difference between it and irssi for dependencies would be that it doesn't have +perl and instead always builds for perl support. If it was going slowly, it could be their slow subversion server, which I've seen on more than one occasion.

Have you looked at port irssistats. I gave it a shot, I think that port needs some looking into to work in a useful way. I could not get it to work, but it sounds like it is a cool idea. I may take a poke at seeing what it takes to make it work better, unless you use it and know the tricks to getting it to work.

comment:10 Changed 10 years ago by blb@…

I haven't tried out irssistats, mostly because I don't have irssi do logging...

Note: See TracTickets for help on using tickets.