libsdl 1.2.14_3 fails in SDL_cpuinfo.c on i386

[skymoo (Adam Mercer)]

Getting the following build error from libsdl 1.2.14_3 on Intel Leopard:

 /usr/bin/gcc-4.0 -O2 -arch i386 -I/opt/local/include -I./include -D_GNU_SOURCE=1 -DTARGET_API_MAC_CARBON -DTARGET_API_MAC_OSX -fvisibility=hidden -I/opt/local/include -DXTHREADS -D_THREAD_SAFE -force_cpusubtype_ALL -fpascal-strings -c ./src/cpuinfo/SDL_cpuinfo.c  -fno-common -DPIC -o build/.libs/SDL_cpuinfo.o
./src/cpuinfo/SDL_cpuinfo.c: In function 'SDL_GetCPUFeatures':
./src/cpuinfo/SDL_cpuinfo.c:150: error: PIC register '%ebx' clobbered in 'asm'
./src/cpuinfo/SDL_cpuinfo.c:150: error: PIC register '%ebx' clobbered in 'asm'
./src/cpuinfo/SDL_cpuinfo.c:220: error: PIC register '%ebx' clobbered in 'asm'
./src/cpuinfo/SDL_cpuinfo.c:220: error: PIC register '%ebx' clobbered in 'asm'
./src/cpuinfo/SDL_cpuinfo.c:220: error: PIC register '%ebx' clobbered in 'asm'
./src/cpuinfo/SDL_cpuinfo.c:150: error: PIC register '%ebx' clobbered in 'asm'
./src/cpuinfo/SDL_cpuinfo.c:150: error: PIC register '%ebx' clobbered in 'asm'
 /usr/bin/gcc-4.0 -O2 -arch i386 -I/opt/local/include -I./include -D_GNU_SOURCE=1 -DTARGET_API_MAC_CARBON -DTARGET_API_MAC_OSX -fvisibility=hidden -I/opt/local/include -DXTHREADS -D_THREAD_SAFE -force_cpusubtype_ALL -fpascal-strings -c ./src/events/SDL_active.c  -fno-common -DPIC -o build/.libs/SDL_active.o
make: *** [build/SDL_cpuinfo.lo] Error 1

[jmroot (Joshua Root)]

Seems to have been broken by the patch from this upstream bug: ​http://bugzilla.libsdl.org/show_bug.cgi?id=734

[gale@…]

Also on Tiger, MacBook 2Ghz Intel Core 2 Duo.

Please fix the summary. Besides removing "Leopard", could we please make it more descriptive - add "SDL_cpuinfo.c" or "PIC register" or something - so that careless people like me will stop submitting dupes? Thanks.

[gale@…]

Cc Me!

[jmroot (Joshua Root)]

Patch (should be in the next revision): ​http://www.libsdl.org/cgi/viewvc.cgi/branches/SDL-1.2/src/cpuinfo/SDL_cpuinfo.c?r1=4848&r2=4859&view=patch

[whitley@…]

Cc Me!

[bryeung@…]

Cc Me!

[nox@…]

Either this has been fixed somewhere between libsdl 1.2.14_3 and 1.2.14_6, or jmr patch is not its fix, as it's already in 1.2.14_6 sourcecode.