pango, pango-devel: +quartz doesn't compile on tiger

[neric27@…]

with pango 1.26, some new CTFontRef is used, which is not present in mac OS X Tiger (aka 10.4). I'm afraid this is something which has to be fixed upstream...

The error is :

Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_x11_pango/work/pango-1.26.0" && /usr/bin/make -j1 all " returned error 2
Command output: /usr/bin/make  all-recursive
Making all in pango
  GEN    pango-enum-types.h
  GEN    pango-enum-types.c
/usr/bin/make  all-recursive
Making all in opentype
make[4]: Nothing to be done for `all'.
Making all in mini-fribidi
make[4]: Nothing to be done for `all'.
  GEN    pango-enum-types.h
  GEN    pango-enum-types.c
  CC     libpangocairo_1_0_la-pangocairo-atsuifont.lo
pangocairo-atsuifont.c: In function 'pango_cairo_atsui_font_create_metrics_for_context':
pangocairo-atsuifont.c:123: error: 'CTFontRef' undeclared (first use in this function)
pangocairo-atsuifont.c:123: error: (Each undeclared identifier is reported only once
pangocairo-atsuifont.c:123: error: for each function it appears in.)
pangocairo-atsuifont.c:123: error: parse error before 'ct_font'
pangocairo-atsuifont.c:132: error: 'ct_font' undeclared (first use in this function)
pangocairo-atsuifont.c:132: warning: implicit declaration of function 'CTFontCreateWithGraphicsFont'
pangocairo-atsuifont.c:136: warning: implicit declaration of function 'CTFontGetAscent'
pangocairo-atsuifont.c:137: warning: implicit declaration of function 'CTFontGetDescent'
pangocairo-atsuifont.c:139: warning: implicit declaration of function 'CTFontGetUnderlinePosition'
pangocairo-atsuifont.c:140: warning: implicit declaration of function 'CTFontGetUnderlineThickness'
make[4]: *** [libpangocairo_1_0_la-pangocairo-atsuifont.lo] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

[neric27@…]

the offensive commit is here : ​http://git.gnome.org/cgit/pango/commit/?id=01783de926a09dd8a3b11699bc8b1a6b6dce0556

In WebKit for instance, they seem to maintain compatibility ​http://trac.webkit.org/changeset/30997.

I'm not a Cocoa developer, so I can't propose any patch. The obvious would be to back-apply the pango commit and hope for the best.

[ryandesign (Ryan Carsten Schmidt)]

with pango 1.26, some new CTFontRef is used, which is not present in mac OS X Tiger (aka 10.4). I'm afraid this is something which has to be fixed upstream...

I agree. I assume upstream is already aware of the problem since it has been noted on the pango mailing list ​here and ​here. For now I marked the quartz variant as requiring 10.5 or greater in r58387. If upstream changes pango to once again make quartz possible on 10.4, let me know and I'll remove this restriction again.

[elelay (Eric Le Lay)]

Replying to ryandesign@…:

If upstream changes pango to once again make quartz possible on 10.4, let me know and I'll remove this restriction again.

Hi Ryan, I tried pango 1.28.0 +quartz this morning and it builds and works well. It fixes an issue in ​gPodder when subscribing to a podcast containing text written in Hebrew.

The ​upstream bug is still open though...

[elelay (Eric Le Lay)]

Cc Me!

[jmroot (Joshua Root)]

Fixed for pango in r72474.

[ryandesign (Ryan Carsten Schmidt)]

Fixed for pango-devel in r79553.