Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#2366 closed defect (fixed)

Add new option destroot.keepdirs to eliminate need for .turd files

Reported by: jberry@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: base Version: 1.0
Keywords: Cc:
Port:

Description

Patch file attached.

.turd files have traditionally been used to prevent empty directories that are actually needed, from being deleted during the destroot phase. But .turd files are ugly, and cause a variety of ugly complications as well.

The attached patch adds a new option destroot.keepdirs which accepts a list of paths in destroot that should be "kept".

The implementation simply adds additional options to the find command which searches for empty directories, in order to exclude these "keepdirs" from the search.

The directories to keep are specified by full paths into the destroot. My only question on this patch is whether specifying these as destroot paths is appropriate, or whether they should be specified relative to prefix.

Attachments (1)

portdestroot.tcl.diff (1.4 KB) - added by jberry@… 12 years ago.
Patch to base/src/port1.0/portdestroot.tcl

Download all attachments as: .zip

Change History (2)

Changed 12 years ago by jberry@…

Patch to base/src/port1.0/portdestroot.tcl

comment:1 Changed 12 years ago by jkh@…

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.