Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#25262 closed defect (fixed)

openload: patch to fix compile issue in snow leopard

Reported by: smibrahim@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.0
Keywords: maintainer haspatch Cc:
Port: openload

Description

someone please commit the attached portfile and patch file for port openload

Attachments (2)

portfile (1006 bytes) - added by smibrahim@… 10 years ago.
portfile
patch-src-tmplchunk.h.diff (542 bytes) - added by smibrahim@… 10 years ago.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by smibrahim@…

Attachment: portfile added

portfile

Changed 10 years ago by smibrahim@…

Attachment: patch-src-tmplchunk.h.diff added

comment:1 Changed 10 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned
Summary: patch to fix openload compile issue in snow leopardopenload: patch to fix compile issue in snow leopard

comment:2 Changed 10 years ago by ryandesign (Ryan Schmidt)

Keywords: maintainer haspatch added
Resolution: fixed
Status: assignedclosed

Committed in r68834. In the future please submit unified diffs, not complete portfiles, so we can better evaluate your proposed changes.

Your new portfile appears to be based on the version you originally submitted in #19363 and not the version that got committed to the repository. Your new portfile did not include the post-destroot section currently in the port that installs the documentation files, and it did include --bindir and --mandir configure args that are not necessary and never got committed before. Bryan explained in #19363 why these changes were made and you agreed to them. You should always base your diffs on the version currently in the repository.

I was unable to locate any distfile for an openload 0.1.2.1. Since you did not change the checksums, I assumed you meant to keep the version at 0.1.2 but increase the revision to 1. This also suggests to me you did not test this modification before submitting it here. Please test your modifications in the future before submitting.

comment:3 Changed 10 years ago by smibrahim@…

thanks, understood my mistake :( .

Note: See TracTickets for help on using tickets.