Opened 11 years ago

Closed 11 years ago

#25267 closed submission (fixed)

sane-frontends 1.0.15git

Reported by: aguynamedryan+macports@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.0
Keywords: Cc:
Port: sane-frontends

Description

I'd like to add sane-frontends to the list of available ports.

sane-frontends provides additional programs for use with sane-backends, such as scanadf.

sane-frontends has not released an updated tarball in the last 5 years, but there have been a few minor updates to it to maintain compatibility with API changes in sane-backends. To that end, the portfile I have created uses git to pull the latest version from the repo.

The Portfile I have submitted builds sane-frontends successfully under Mac OS X 10.6.3

Attachments (4)

Portfile (1.1 KB) - added by aguynamedryan+macports@… 11 years ago.
Portfile to build sane-frontends
Portfile.2 (1.2 KB) - added by ryandesign (Ryan Schmidt) 11 years ago.
revised by ryandesign
Portfile.3 (1.2 KB) - added by aguynamedryan+macports@… 11 years ago.
Portfile with git.branch set
Portfile.4 (1.2 KB) - added by aguynamedryan+macports@… 11 years ago.
Changed version to 1.0.15git

Download all attachments as: .zip

Change History (12)

Changed 11 years ago by aguynamedryan+macports@…

Attachment: Portfile added

Portfile to build sane-frontends

comment:1 Changed 11 years ago by aguynamedryan+macports@…

Cc: aguynamedryan+macports@… added

Cc Me!

comment:2 Changed 11 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added; aguynamedryan+macports@… removed
Port: sane-frontends added

Please fill in the port field, and note you do not need to Cc yourself.

I'm attaching a revised portfile with these changes:

  • removed revision line -- the first revision of any given version should be 0 not 1
  • obfuscated your maintainer email address to prevent it from being harvested by spambots
  • whitespace changes to make things line up

It builds for me on 10.6.4, but before it can be committed, some mechanism needs to be employed to ensure that the version downloaded is fixed in time; it's not ok for the port to just download the currently-available version of the software. You will probably want to use the git.branch variable for this.

Changed 11 years ago by ryandesign (Ryan Schmidt)

Attachment: Portfile.2 added

revised by ryandesign

comment:3 Changed 11 years ago by ryandesign (Ryan Schmidt)

One more change:

  • removed the configure.args; the --mandir arg was unnecessary because sane-frontends already knows the proper location for manpages, and the --with-docdir arg was unnecessary because sane-frontends doesn't install any documentation

Changed 11 years ago by aguynamedryan+macports@…

Attachment: Portfile.3 added

Portfile with git.branch set

comment:4 Changed 11 years ago by aguynamedryan+macports@…

Thanks for all the help and advice!

comment:5 Changed 11 years ago by ryandesign (Ryan Schmidt)

That looks good, thanks.

Don't forget to ensure your whitespace matches. I had fixed the portfile to use only spaces for indentation, but the line you added used tabs which assumed the editor was configured for two spaces per tab. Spaces only (no tabs), at four spaces per indentation, is the preferred indentation style of the MacPorts project.

You've listed the port version as 1.0.14, however:

$ scanadf --version
scanadf (sane-frontends) 1.0.15git

Should we set the version to 1.0.15git instead?

comment:6 in reply to:  5 Changed 11 years ago by aguynamedryan+macports@…

Replying to ryandesign@…: 1.0.15git sounds good to me. Sorry about the whitespace issues. I thought I had converted tabs to spaces before I saved. Hopefully the latest Portfile is correctly spaced.

Thanks again for all your help!

Changed 11 years ago by aguynamedryan+macports@…

Attachment: Portfile.4 added

Changed version to 1.0.15git

comment:7 Changed 11 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… removed
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

comment:8 Changed 11 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed
Summary: sane-frontends 1.0.14sane-frontends 1.0.15git

Looks good to me! Committed in r68929.

Note: See TracTickets for help on using tickets.