Opened 11 years ago

Closed 11 years ago

#25477 closed update (fixed)

fig2ps version update

Reported by: jjstickel@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: maintainer haspatch Cc:
Port: fig2ps

Description

A new version of fig2ps is available. I'll attach a patch for the Portfile.

Attachments (1)

fig2ps_Portfile.diff (1.6 KB) - added by jjstickel@… 11 years ago.

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by jjstickel@…

Attachment: fig2ps_Portfile.diff added

comment:1 Changed 11 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks, I'll commit it in a moment after I've tested it builds. (Waiting on openmotif...)

The modeline you added indicates tabs are to be considered as 2 spaces each. But the existing indentation of the Portfile seems to have assumed that tabs should be considered as 8 spaces each. And the preferred Portfile indentation style is to indent at 4 spaces and to use spaces, not tabs. May I change the modeline to the standard MacPorts one and reindent the Portfile to this style?

comment:2 in reply to:  1 Changed 11 years ago by jjstickel@…

Replying to ryandesign@…:

The modeline you added indicates tabs are to be considered as 2 spaces each. But the existing indentation of the Portfile seems to have assumed that tabs should be considered as 8 spaces each. And the preferred Portfile indentation style is to indent at 4 spaces and to use spaces, not tabs. May I change the modeline to the standard MacPorts one and reindent the Portfile to this style?

The only thing I know about modelines is that I get color syntax highlighting in my emacs editor when they are present! In fact, the automatic indentation doesn't even seem to work for me. I copied that modeline from some other Portfile (don't remember which one). You may change the modeline and adjust the indentation.

comment:3 Changed 11 years ago by ryandesign (Ryan Schmidt)

Thanks, added modeline and updated whitespace in r69358. Now waiting on texlive to build...

comment:4 Changed 11 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

Updated to 1.5 in r69366. Also added the "supported_archs noarch" line since this port does not install any architecture-specific files.

Note: See TracTickets for help on using tickets.