Opened 14 years ago

Closed 13 years ago

#25798 closed update (fixed)

poco: Update to 1.3.6p2

Reported by: mp.naq1@… Owned by: nox@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: ryandesign (Ryan Carsten Schmidt), nimahoda@…
Port: poco

Description

I've created a diff to update Poco to 1.3.6p2.

Attachments (4)

Portfile-rrdtool.diff (2.4 KB) - added by mp.naq1@… 14 years ago.
Portfile Diff
Portfile (4.9 KB) - added by mp.naq1@… 14 years ago.
Portfile
poco_1.3.6p2_compiler_arch.patch (986 bytes) - added by nimahoda@… 14 years ago.
Make poco build for build_arch using configure.{cc,xx,cpp} compiler instead of choosing on its own.
poco_1.3.6p2_update.patch (10.6 KB) - added by nimahoda@… 13 years ago.

Download all attachments as: .zip

Change History (15)

Changed 14 years ago by mp.naq1@…

Attachment: Portfile-rrdtool.diff added

Portfile Diff

Changed 14 years ago by mp.naq1@…

Attachment: Portfile added

Portfile

comment:1 Changed 14 years ago by jmroot (Joshua Root)

Cc: nox@… removed
Keywords: haspatch added; POCO C++ Libraries removed
Owner: changed from macports-tickets@… to nox@…
Version: 1.9.1

Changed 14 years ago by nimahoda@…

Make poco build for build_arch using configure.{cc,xx,cpp} compiler instead of choosing on its own.

comment:2 Changed 14 years ago by nimahoda@…

Thanks mp.naq1 for updating the port.

The attached poco_1.3.6p2_compiler_arch.patch corrects the Poco build's default choice of Darwin_i386 instead of using build_arch (rather accepting the --target option in configure) and it's hardcoded choice of gcc4.0. This fixes some issues I was having linking against 64-bit binaries and using the debug versions of the library (debug namespace for gcc's stl has changed between 4.0 and 4.2).

The patch applies after the Portfile-rrdtool.diff patch.

$ cd devel/poco
$ patch < -p0 Portfile-rrdtool.diff
$ patch < -p0 poco_1.3.6p2_compiler_arch.patch

Cheers,
-Nima

comment:3 Changed 14 years ago by mp.naq1@…

Nima, The patch looks good. However, I'm not the maintainer to this port.

I think you'll have to create a new ticket for this following these guidelines: http://guide.macports.org/#project.update-policies.nonmaintainer

The patch that I did was added pretty quickly, so I think yours will be too.

Thanks for fixing those issues! Sometimes developing for OS X can be a chore ;)

Regards, Mike

comment:4 Changed 13 years ago by nimahoda@…

Cc: nimahoda@… added

Cc Me!

comment:5 Changed 13 years ago by nimahoda@…

Cc: nimahoda@… removed

Cc Me!

comment:6 Changed 13 years ago by nimahoda@…

Thanks for the tip. Sorry it took me so long to see it!

comment:7 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

The new ticket for the architecture fixes patch is #27763.

The current release of poco is now 1.4.0.

comment:8 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Summary: Update Poco to 1.3.6p2poco: Update to 1.3.6p2

The patch proposed in this ticket changes the distfile from the bz2 file to the gz file; I would not make this change, since the bz2 file is smaller than the gz file and thus preferred.

It also suggests to change the documentation distfile format from gz to zip; again, I would not make this change, since the gz file is smaller than the zip file.

comment:9 Changed 13 years ago by nimahoda@…

Cc: nimahoda@… added

Cc Me!

Changed 13 years ago by nimahoda@…

Attachment: poco_1.3.6p2_update.patch added

comment:10 in reply to:  8 Changed 13 years ago by nimahoda@…

Replying to ryandesign@…:

The patch proposed in this ticket changes the distfile from the bz2 file to the gz file; I would not make this change, since the bz2 file is smaller than the gz file and thus preferred.

It also suggests to change the documentation distfile format from gz to zip; again, I would not make this change, since the gz file is smaller than the zip file.

Please take a look at the new patch: poco_1.3.6p2_update.patch

comment:11 Changed 13 years ago by eborisch (Eric A. Borisch)

Resolution: fixed
Status: newclosed

Commited (with documentation distname tweak and non-universal flag) in [75072]

Note: See TracTickets for help on using tickets.