Opened 10 years ago

Closed 10 years ago

#25880 closed defect (fixed)

Quiet (-q) option does not suppress port lint or fetch output

Reported by: ryandesign (Ryan Schmidt) Owned by: raimue (Rainer Müller)
Priority: Normal Milestone: MacPorts 1.9.2
Component: base Version: 1.9.1
Keywords: Cc: wsiegrist@…, anddam (Andrea D'Amore)
Port:

Description

I've received the following two emails today in response to my commits. Previously I would only receive a lint report when lint found something wrong, which would be preferable.

From: noreply@macports.org
Date: July 30, 2010 13:29:29 CDT
To: ryandesign@macports.org,
Subject: [70152] dblatex Lint Report

Change: http://trac.macports.org/changeset/70152
Portfile: dblatex

--->  Verifying Portfile for dblatex
--->  0 errors and 0 warnings found.
From: noreply@macports.org
Date: July 30, 2010 14:33:23 CDT
To: ryandesign@macports.org, mcalhoun@macports.org,
Subject: [70153] gmp Lint Report

Change: http://trac.macports.org/changeset/70153
Portfile: gmp

--->  Verifying Portfile for gmp
--->  0 errors and 0 warnings found.

Change History (17)

comment:1 Changed 10 years ago by ryandesign (Ryan Schmidt)

And also I received an email when updating a port to a new version:

From: noreply@macports.org
Date: July 31, 2010 00:25:13 CDT
To: ryandesign@macports.org, jwa@macports.org,
Subject: [MacPorts Mirror] Portfile Mirror Errors for: wine-devel

Portfile: wine-devel 


Errors: --->  Attempting to fetch wine-1.3.0.tar.bz2 from http://distfiles.macports.org/wine
--->  Attempting to fetch wine-1.3.0.tar.bz2 from http://downloads.sourceforge.net/wine

No error actually occurred; the new distfile has been successfully fetched by the distfiles mirror.

comment:2 Changed 10 years ago by wsiegrist@…

Component: server/hostingbase
Owner: changed from wsiegrist@… to jmr@…
Summary: lint reports are being sent when there's nothing wrongQuiet (-q) option does not suppress port lint output
Version: 1.9.1

Looks like using "-q" with port lint is not suppressing the "no errors" output like it did with MacPorts v1.8. Sending to jmr to see if this was planned (we can change the server's scripts if so).

comment:3 Changed 10 years ago by jmroot (Joshua Root)

Cc: raimue@… added

I vaguely recall Rainer changing something to do with the ui_* levels visibility...

comment:4 Changed 10 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

trunk r70163, branch r70164

comment:5 Changed 10 years ago by jmroot (Joshua Root)

Milestone: MacPorts 1.9.2

comment:6 Changed 10 years ago by ryandesign (Ryan Schmidt)

Cc: wsiegrist@… added

Thanks. We should then either release 1.9.2 soon or update the server with these changes before 1.9.2 is released so that the server stops sending these irrelevant emails.

comment:7 Changed 10 years ago by wsiegrist@…

Patch applied to servers. Emails should stop, let me know if they don't.

comment:8 Changed 10 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: closedreopened
Summary: Quiet (-q) option does not suppress port lint outputQuiet (-q) option does not suppress port lint or fetch output

The lint emails are no longer arriving, but the fetch emails still are. Looks like r70163 / r70164 only dealt with lint, not fetch.

comment:9 Changed 10 years ago by raimue (Rainer Müller)

I guess this would be true for all phases and it's not a good solution to handle fetch and lint differently just for the mails. Do we really want no output for all port targets (notes on activate, startupitem, livecheck, ...)?

comment:10 Changed 10 years ago by wsiegrist@…

As I see it, "quiet" really means no output. Otherwise, what would this option do? Perhaps we can have multiple levels of quiet? "-q" for what it is before this ticket's patch, "-qq" for no output except for errors. Maybe "-qqq" for no output at all. And of course, I can always just rework the server scripts to not rely on "-q" if the quiet option is meant to do something else.

comment:11 Changed 10 years ago by jmroot (Joshua Root)

The intent of quiet mode is to suppress all output that is not essential to the purpose of the command. So for an action like installed, it only prints the list of installed ports, not the "The following ports are currently installed:" preface. For actions that do something, as opposed to returning information, "silence is golden".

comment:12 Changed 10 years ago by anddam (Andrea D'Amore)

Cc: and.damore@… added

Cc Me!

comment:13 Changed 10 years ago by wsiegrist@…

We also applied r70594 to the server to fix the auto mirror emails

comment:14 Changed 10 years ago by jmroot (Joshua Root)

Cc: raimue@… removed
Owner: changed from jmr@… to raimue@…
Status: reopenednew

comment:15 Changed 10 years ago by raimue (Rainer Müller)

Status: newassigned

As of r70974, only distfiles and livecheck will print any messages when quiet mode is enabled. Warnings and errors will always be displayed as they are important and are printed on stderr anyway. Please test if this now works as expected.

The lint action is a bit special as it always prints warnings and errors. For clarity, shouldn't it report on stdout as it is not reporting actual runtime errors?

comment:16 Changed 10 years ago by wsiegrist@…

The mirror and lint servers have been updated to r71046.

comment:17 Changed 10 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: assignedclosed

The original bug reported here is fixed.

Note: See TracTickets for help on using tickets.