Opened 14 years ago

Closed 14 years ago

#26030 closed defect (fixed)

pkg.m4 underquoting with autoconf-2.66+

Reported by: skymoo (Adam Mercer) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: High Milestone:
Component: ports Version:
Keywords: Cc: EJFielding (Eric Fielding), sewebster@…
Port: pkgconfig

Description

autoconf-2.66+ exposes an apparent underquoting bug in pkg.m4 that was causing some ports (such as xorg-libXp) to fail with errors of the form:

configure:12439: error: possibly undefined macro: AS_MESSAGE_LOG_FDdnl
     If this token and others are legitimate, please use m4_pattern_allow.
     See the Autoconf documentation.

The attached patches add the appropriate quoting that fixes these errors.

Attachments (2)

Portfile.diff (670 bytes) - added by skymoo (Adam Mercer) 14 years ago.
patch-underquoting.diff (286 bytes) - added by skymoo (Adam Mercer) 14 years ago.

Download all attachments as: .zip

Change History (12)

Changed 14 years ago by skymoo (Adam Mercer)

Attachment: Portfile.diff added

Changed 14 years ago by skymoo (Adam Mercer)

Attachment: patch-underquoting.diff added

comment:1 Changed 14 years ago by EJFielding (Eric Fielding)

Can somebody describe where and how to apply these patches? I am new to MacPorts and dead in the water right now.

comment:2 Changed 14 years ago by EJFielding (Eric Fielding)

Cc: Eric.J.Fielding@… added

Cc Me!

comment:3 Changed 14 years ago by sewebster@…

Briefly: Change the portfile in /opt/local/var/macports/sources/rsync.macports.org/release/ports/devel/pkgconfig as per the diff and then create a directory called files in that same directory and put the other .diff file in it. Then install pkgconfig again.

comment:4 Changed 14 years ago by sewebster@…

Cc: sewebster@… added

Cc Me!

comment:5 Changed 14 years ago by sewebster@…

port name is actually pkgconfig

comment:6 in reply to:  3 Changed 14 years ago by EJFielding (Eric Fielding)

Replying to sewebster@…:

Briefly: Change the portfile in /opt/local/var/macports/sources/rsync.macports.org/release/ports/devel/pkgconfig as per the diff and then create a directory called files in that same directory and put the other .diff file in it. Then install pkgconfig again.

Thanks!! I am back under sail again.

comment:7 Changed 14 years ago by skymoo (Adam Mercer)

Port: pkgconfig added; pkg-config removed

comment:8 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Status: newassigned

comment:9 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Priority: NormalHigh

comment:10 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Thank you for the patch, which I've applied it r70479.

Note: See TracTickets for help on using tickets.