Opened 9 years ago

Closed 9 years ago

#26301 closed defect (fixed)

openjdk6-b16-1 Build fail on Core Solo CPU

Reported by: daniel.hjort@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: haspatch Cc: landonf@…
Port: openjdk6

Description (last modified by mf2k (Frank Schima))

The build failed on a Core Solo Mac Mini.

Log:

cd bsd_i486_compiler2/product && /usr/bin/make
make: the `-j' option requires a positive integral argument

This line in the Portfile is wrong:

HOTSPOT_BUILD_JOBS=[expr [exec sysctl -n hw.ncpu] - 1]

Expression evaluates to 0 on single core machines. In patch changed to +1 which is common for build optimization.

Attachments (1)

Portfile.diff (457 bytes) - added by daniel.hjort@… 9 years ago.
Portfile patch

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by daniel.hjort@…

Attachment: Portfile.diff added

Portfile patch

comment:1 Changed 9 years ago by mf2k (Frank Schima)

I don't see the point of making it +1. If you have 2 processors, how can it use 3? I would say just remove the -1 or put a conditional for the case that it is 0.

comment:2 Changed 9 years ago by mf2k (Frank Schima)

Description: modified (diff)

comment:3 Changed 9 years ago by daniel.hjort@…

Yes you are correct if compiling would be a matter of just raw processing. But the jobs will sometimes wait for IO and then the n+1 job can do some of it's work.

comment:4 Changed 9 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

Switched to using the build.jobs variable in r71104 (no need to do any calculations).

Note: See TracTickets for help on using tickets.