Opened 9 years ago

Closed 8 years ago

#26410 closed update (fixed)

wxwidgets-devel v2.9.1

Reported by: pixilla (Bradley Giesbrecht) Owned by: jyrkiwahlstedt
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: tvb377@…, michaelld (Michael Dickens), raimue (Rainer Müller), stevecheckoway (Stephen Checkoway), l2g@…, wmiler@…, mjhsieh@…, anddam (Andrea D'Amore)
Port: wxWidgets-devel

Description

The port file was not making sense to me and the development sources appear to be on sourceforge so I made more then the minimal changes to Portfile.

If you only want to solve the install_name_tool issue just look at patch-configure.diff. It is a one liner.

Attachments (5)

patch-wxwidgets-devel-v2.9.1.diff (7.4 KB) - added by pixilla (Bradley Giesbrecht) 9 years ago.
Portfile-wxWidgets-devel.diff (3.5 KB) - added by tvb377@… 9 years ago.
corrections necessary after r71416
wxWidgets-devel-2.9.1-Portfile (2.7 KB) - added by stevecheckoway (Stephen Checkoway) 8 years ago.
Different Portfile
patch-configure-change_install_names.diff (2.6 KB) - added by stevecheckoway (Stephen Checkoway) 8 years ago.
Patch to generated change_install_names script
combined_patch-wxwidgets-devel.diff (8.1 KB) - added by anddam (Andrea D'Amore) 8 years ago.

Download all attachments as: .zip

Change History (24)

Changed 9 years ago by pixilla (Bradley Giesbrecht)

comment:1 Changed 9 years ago by tvb377@…

Cc: jwa mww tvb377@… added; jwa mww removed

Cc Me!

comment:2 Changed 9 years ago by tvb377@…

I would implement the correction of the library paths in the Portfile. See suggested diff attached. Anyway, I also made more than minimal changes; at least the variant changes should be implemented in the upgrade.

comment:3 Changed 9 years ago by michaelld (Michael Dickens)

Cc: michaelld@… added

Cc Me!

comment:4 Changed 9 years ago by ryandesign (Ryan Schmidt)

Cc: mww@… added; jwa mww removed
Owner: changed from macports-tickets@… to jwa@…

Cc field must contain complete email addresses.

comment:5 Changed 9 years ago by pixilla (Bradley Giesbrecht)

Cc: brad@… added

Cc Me!

comment:6 Changed 9 years ago by jyrkiwahlstedt

Resolution: fixed
Status: newclosed

done in r71416

comment:7 Changed 9 years ago by tvb377@…

Resolution: fixed
Status: closedreopened

You did not apply the patch Portfile-wxWidgets-devel.diff
--> The added variants are missing
--> The variant debug is still not corrected
--> The libraries dependencies do not work this way.

Why not simply apply the patch? It's not *that* bad.

Changed 9 years ago by tvb377@…

corrections necessary after r71416

comment:8 Changed 9 years ago by raimue (Rainer Müller)

Cc: raimue@… added

I took a look at your patch, but actually I don't understand already why the unmodified Portfile is doing things in this way.

Usually *-devel ports use the same paths as the original ports, so they can be used as a immediate replacement for testing. What is really missing here are conflict statements in wxwidgets and wxwidgets-devel in my opinion and they should use the same paths.

Does this new version break API so that it won't be compatible at all with other ports or is there another reason to use different paths?

comment:9 Changed 9 years ago by tvb377@…

The released wxWidgets 2.9.0 was of no great use for production software, maybe that's why the original Portfile author went this way.

Currently, I'm not using much of wxWidgets in my projects, my code compiles and works with 2.9.1. Some time ago I ported CodeLite to a snapshot of wx > 2.9.0 just to see if it is useable and this was not too lengthy or difficult (see also wx change documentation).

In my opinion it would be good to endorse usage of wx > 2.8 for compatibility with x86_64 (and who knows when Apple decides to remove Carbon completely).

But I just spent some minutes trying to compile pgAdmin with wx 2.9.1 Besides some character type conversion errors which might be easy to fix this fails because it requires wxOGL. wxOGL is noted as dead on some wikis and was moved out of wxWidgets. It does not compile with 2.9.1.

All not too difficult, but IMO not the job of a macport.

--> I'd leave it as is.

comment:10 Changed 8 years ago by stevecheckoway (Stephen Checkoway)

I made a different version of the wxWidgets-devel port that uses Cocoa always, removes SDL (is that actually needed for anything in wxWidgets?) and seems to work on Mac OS X 10.5 ppc and 10.6 x86_64.

The various patches I've seen to fix the install names for the libraries don't work correctly or completely. The patch to configure and configure.in leverages the change_install_names script that is run post install to change the install name for the two libraries and the binary.

Changed 8 years ago by stevecheckoway (Stephen Checkoway)

Different Portfile

Changed 8 years ago by stevecheckoway (Stephen Checkoway)

Patch to generated change_install_names script

comment:11 Changed 8 years ago by stevecheckoway (Stephen Checkoway)

Cc: s@… added

Cc Me!

comment:12 Changed 8 years ago by l2g@…

Cc: l2g@… added

Cc Me!

comment:13 Changed 8 years ago by wmiler@…

Cc: wmiler@… added

Cc Me!

comment:14 Changed 8 years ago by jmroot (Joshua Root)

Cc: mww@… brad@… removed
Reporter: changed from brad@… to pixilla@…

Brad, this is well and truly timed out; if you're sure your configure patch is correct you can commit it.

comment:15 Changed 8 years ago by mjhsieh@…

Cc: mjhsieh@… added

Cc Me!

comment:16 Changed 8 years ago by anddam (Andrea D'Amore)

Cc: and.damore@… added

Cc Me!

comment:17 Changed 8 years ago by anddam (Andrea D'Amore)

Using wxWidgets-devel-2.9.1-Portfile and patch-configure-change_install_names.diff I have an error in destroot phase for change-install-names script, here's the relevant output (lines broken at 80 chars):

/opt/local/var/macports/build/_opt_local_var_macports_sources_svn.macports.
/org_trunk_dports_graphics_wxWidgets-devel/wxWidgets-devel/work/wxWidgets-2.9.1/
/build/change-install-names
//opt/local/var/macports/build/_opt_local_var_macports_sources_svn.macports.
/org_trunk_dports_graphics_wxWidgets-devel/wxWidgets-devel/work/destroot/opt/
/local/lib
//opt/local/var/macports/build/_opt_local_var_macports_sources_svn.macports.
/org_trunk_dports_graphics_wxWidgets-devel/wxWidgets-devel/work/destroot/opt/
/local/bin /opt/local/lib
//opt/local/var/macports/build/_opt_local_var_macports_sources_svn.macports.
/org_trunk_dports_graphics_wxWidgets-devel/wxWidgets-devel/work/wxWidgets-2.9.1/
/build/lib
Usage: install_name_tool [-change old new] ... [-rpath old new] ... [-add_rpath
new] ... [-delete_rpath old] ... [-id name] input make: *** [install] Error 1

comment:18 Changed 8 years ago by anddam (Andrea D'Amore)

Issue solved, the find instructions was using '+' and therefore needs -E in order to use extended regexp.

I'm attaching a combined patch for wxWidgets-devel port, Portfile has whitespace changes.

This is actual output after install:

$ otool -L libwx_osx_cocoau-2.9.1.0.0.dylib
libwx_osx_cocoau-2.9.1.0.0.dylib:
	/opt/local/lib/libwx_osx_cocoau-2.9.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
[…]
$ otool -L libwx_osx_cocoau_gl-2.9.1.0.0.dylib
libwx_osx_cocoau_gl-2.9.1.0.0.dylib:
	/opt/local/lib/libwx_osx_cocoau_gl-2.9.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)

Changed 8 years ago by anddam (Andrea D'Amore)

comment:19 Changed 8 years ago by pixilla (Bradley Giesbrecht)

Resolution: fixed
Status: reopenedclosed

Fixed r79389

Note: See TracTickets for help on using tickets.