Opened 13 years ago

Closed 13 years ago

#27448 closed enhancement (fixed)

lp_solve: add +universal variant

Reported by: devernay (Frédéric Devernay) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: lp_solve

Description

The math/lp_solve port did not build universal. The attached patch fixes this.

Attachments (1)

lp_solve.patch​ (2.7 KB) - added by devernay (Frédéric Devernay) 13 years ago.
port patch (fixed library prefix issues)

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by devernay (Frédéric Devernay)

Attachment: lp_solve.patch​ added

port patch (fixed library prefix issues)

comment:1 Changed 13 years ago by mf2k (Frank Schima)

Keywords: haspatch added
Owner: changed from macports-tickets@… to ryandesign@…
Port: lp_solve added
Version: 1.9.2

comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Status: new → assigned
Summary: add lp_solve +universal variant → lp_solve: add +universal variant

Thanks. I think I'll change the patch a little, to use parentheses around variables ("$(PREFIX)") instead of curly braces ("${PREFIX}") in the Makefile to match the rest of the Makefile. I'll also add "install" to the ".PHONY" line.

In the Portfile, I'll move the common build.args ("PREFIX="${prefix}"") out of the conditional. And I'll replace the hardcoded list of universal architectures with "${configure.universal_archs}". Since this patch doesn't change how the port builds nonuniversally, I won't increase the revision.

comment:3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: → fixed
Status: assigned → closed

Committed in r73807.

Note: See TracTickets for help on using tickets.