Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#27846 closed update (fixed)

upgrade of hugin-app to version 2010.4.0

Reported by: hvdwolf@… Owned by: p.schmiedeskamp@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: ryandesign (Ryan Schmidt)
Port: hugin-app

Description

Recently Hugin got upgraded to 2010.4.0. The 0.7 version inside MacPorts is very, very outdated. Please commit this patch which will upgrade hugin to the latest stable release.

Attachments (1)

Portfile.diff (1.8 KB) - added by hvdwolf@… 10 years ago.
Corrected patch

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by jmroot (Joshua Root)

Cc: p.schmiedeskamp@… removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to p.schmiedeskamp@…
Version: 1.9.2

comment:2 Changed 10 years ago by jmroot (Joshua Root)

Everything below "use_parallel_build no" shouldn't be there. You should use supported_archs rather than overriding configure.build_arch. And does this really require a flat namespace?

comment:3 Changed 10 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added

Thanks. Looks like Joshua beat me to it, but I wrote a few comments on your patch:

  • You've renamed the port from hugin-app to hugin. We would need to retain a stub port of hugin-app marked as being "replaced_by hugin" to facilitate upgrades.
  • You've added yourself as maintainer. Has the current maintainer agreed to this? Admittedly he has been rather absent and may have abandoned the port. See other tickets.
  • You don't need to write "extract.suffix .tar.bz2"; that is the default when you use "use_bzip2 yes".
  • You shouldn't manually set "configure.build_arch"; these days, we set "supported_archs" instead.
  • You don't need to append "configure.cc_archflags" to "configure.ldflags" manually; these days, "configure.ld_archflags" does exist.

comment:4 Changed 10 years ago by jmroot (Joshua Root)

The upstream version appears to be 2010.4.0, so that's what you should set the version field to. That means you don't need to change distname.

comment:5 in reply to:  2 Changed 10 years ago by hvdwolf@…

Replying to jmr@…:

Everything below "use_parallel_build no" shouldn't be there. You should use supported_archs rather than overriding configure.build_arch. And does this really require a flat namespace?

It no longer needs the "-undefined suppress -flat_namespace". It needed that when building universal but that doesn't work nicely. I removed the two settings.

comment:6 in reply to:  3 Changed 10 years ago by hvdwolf@…

Replying to ryandesign@…:

Thanks. Looks like Joshua beat me to it, but I wrote a few comments on your patch:

  • You've renamed the port from hugin-app to hugin. We would need to retain a stub port of hugin-app marked as being "replaced_by hugin" to facilitate upgrades.

It's not a show stopper but the application is called hugin, not hugin-app. When I first searched MacPorts for it I couldn't find it as I searched for hugin. It is nowhere known as hugin-app and definitely not by the hugin community. This hugin-app name is obviously what the current/previous maintainer turned it into. Next to that: hugin consists of three apps and a lot of "helper" cli tools. I would really like to change to hugin as that's the name of the application and the "conglomerate".

  • You've added yourself as maintainer. Has the current maintainer agreed to this? Admittedly he has been rather absent and may have abandoned the port. See other tickets.

I have been working on the MacPorts hugin before, but never committed anything. I mailed the current maintainer twice but that's at least 6-9 months ago. I didn't receive an answer. I did not mail him this time. Sorry, I should have done that. The reason that I made myself (co)maintainer is that I'm the official binary release bundle maintainer for Hugin since 2008. Next to that I build all intermediate development binary bundles (via my own website and via SourceForge) and have fixed all new features that were brought into Hugin by the programmers that didn't run "automatically" on OSX. Off course, I didn't do this alone but needed assistance of the programmers in a number of cases as I'm not a programmer (anymore). The bundles are triple-architecture (ppc/i386/x86_64) universal bundles. Based on these arguments I consider myself a "worthy" (co)maintainer. Next to the binary bundles I now want MacPorts to stay up to date as well.

  • You don't need to write "extract.suffix .tar.bz2"; that is the default when you use "use_bzip2 yes".

Fixed.

  • You shouldn't manually set "configure.build_arch"; these days, we set "supported_archs" instead.

Fixed.

  • You don't need to append "configure.cc_archflags" to "configure.ldflags" manually; these days, "configure.ld_archflags" does exist.

Removed.

Changed 10 years ago by hvdwolf@…

Attachment: Portfile.diff added

Corrected patch

comment:7 Changed 10 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

Committed most of this in r74965, but not the name change because it's kind of a pain.

comment:8 in reply to:  7 Changed 10 years ago by hvdwolf@…

Replying to jmr@…:

Committed most of this in r74965, but not the name change because it's kind of a pain.

OK, thanks for committing. Is it possible to create aliases? In that case a user can both use hugin-app and hugin.

Note: See TracTickets for help on using tickets.