Opened 13 years ago

Closed 12 years ago

#28036 closed defect (fixed)

py26-pyqt4 @4.8.2 syntax error in port_v3 files

Reported by: skurylo+macports@… Owned by: michaelld (Michael Dickens)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc:
Port: py25-pyqt4 py26-pyqt4 py27-pyqt4

Description (last modified by ryandesign (Ryan Carsten Schmidt))

I'm using osx 10.4 and python 2.6, but all 2.x versions should be affected.

When I'm using py2app with a Qt program, all of Qt is pulled in.

Unfortunately this includes the python 3 files in: /opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/site-packages/PyQt4/uic/port_v3/

Fedora and Debian have solved this issue by not including the "port_v3" directory, in their python 2.x Qt packages.

https://bugzilla.redhat.com/show_bug.cgi?id=564633

The key line is 178:

http://pkgs.fedoraproject.org/gitweb/?p=PyQt4.git;a=blob;f=PyQt4.spec;h=924145285e62d066a65b9a5adaceb771f767c190;hb=HEAD

And the Debian version, on line 138:

http://svn.debian.org/wsvn/python-modules/packages/python-qt4/trunk/debian/rules?op=blame&rev=0&sc=0

Macports should do something similar. However I'm not familiar enough with the port file to make the change.

Thank you

Attachments (1)

py-pyqt4-2vs3.patch (810 bytes) - added by jmroot (Joshua Root) 12 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: michaelld@… removed
Description: modified (diff)
Owner: changed from macports-tickets@… to michaelld@…

Changed 12 years ago by jmroot (Joshua Root)

Attachment: py-pyqt4-2vs3.patch added

comment:2 Changed 12 years ago by jmroot (Joshua Root)

Keywords: haspatch added

The attached should do the trick.

comment:3 Changed 12 years ago by michaelld (Michael Dickens)

I didn't have this issue up front. The patch seems to do no harm for my install. I wonder if anyone else can confirm that the patch fixes this ticket?

comment:4 Changed 12 years ago by michaelld (Michael Dickens)

If this ticket is still valid, can you do the following:

sudo port clean py26-pyqt4
sudo port selfupdate

and then try to install or upgrade py26-pyqt4 again. There's a new qt4-mac and py26-pyqt4 that will hopefully fix this issue.

comment:5 Changed 12 years ago by skurylo+macports@…

Unfortunately I no longer have access to a mac, so I wasn't able to try the patch or this new release.

comment:6 Changed 12 years ago by michaelld (Michael Dickens)

The patch looks good to me. Let me test it first & verify, then I'll check it in.

comment:7 Changed 12 years ago by michaelld (Michael Dickens)

Resolution: fixed
Status: newclosed

FIxed in r96669.

Note: See TracTickets for help on using tickets.