Opened 9 years ago

Closed 8 years ago

#28834 closed enhancement (fixed)

cc65 2.13.2: please install some documentation

Reported by: mklein-de (Michael Klein) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc: trashgod@…
Port: cc65

Description

The attached patch installs the html documentation for the cc65 binaries and machine libraries to ${prefix}/share/doc/cc65.

Unfortunately this has a quite big impact on cc65's dependency footprint, though.

Attachments (4)

Portfile.diff (3.8 KB) - added by mklein-de (Michael Klein) 9 years ago.
New Portfile patch with +docs variant (by default enabled)
Portfile.2.diff (3.8 KB) - added by trashgod@… 9 years ago.
New Portfile patch with -docs variant check.
Portfile.3.diff (3.8 KB) - added by trashgod@… 8 years ago.
New Portfile patch with +docs variant, not enabled by default.
cc65.log (58.9 KB) - added by jmroot (Joshua Root) 8 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 9 years ago by trashgod@…

Because of the dependency impact, would this be better as a variant?

comment:2 Changed 9 years ago by jmroot (Joshua Root)

A variant is how most ports do it when building docs requires significant extra dependencies.

comment:3 Changed 9 years ago by trashgod@…

jmr: Thanks for verifying this. I am both swamped and clueless; can you point to an example?

michael.klein: To avoid delay, is a variant something you would be willing/able to do?

comment:4 Changed 9 years ago by mklein-de (Michael Klein)

A variant is something I could do, it might take a couple of days though.

comment:5 Changed 9 years ago by trashgod@…

I'd say go ahead; I won't have the resources to test it for at least a week.

Changed 9 years ago by mklein-de (Michael Klein)

Attachment: Portfile.diff added

New Portfile patch with +docs variant (by default enabled)

comment:6 Changed 9 years ago by mklein-de (Michael Klein)

find updated patch attached

Changed 9 years ago by trashgod@…

Attachment: Portfile.2.diff added

New Portfile patch with -docs variant check.

comment:7 Changed 9 years ago by trashgod@…

Michael: Excellent! reinplace certainly simplifies things. I added a check to post-destroot for -docs in Portfile.2.diff.

comment:8 in reply to:  7 Changed 9 years ago by mklein-de (Michael Klein)

Replying to trashgod@…:

I added a check to post-destroot for -docs in Portfile.2.diff.

yes, missed that one. Thanks for fixing it.

/Michael

comment:9 Changed 8 years ago by mklein-de (Michael Klein)

So can this finally be commited and closed then?

Regards, Michael

Changed 8 years ago by trashgod@…

Attachment: Portfile.3.diff added

New Portfile patch with +docs variant, not enabled by default.

comment:10 Changed 8 years ago by trashgod@…

Due the considerable burden imposed by the +docs variant, it is not enabled by default in Portfile.3.diff. Please commit and close. Sorry for the delay.

comment:11 in reply to:  9 Changed 8 years ago by trashgod@…

Replying to michael.klein@…:

So can this finally be commited and closed then?

Please commit the changes in Portfile.3.diff. Upstream version 2.13.3 is at hand, and it will be slightly easier to start from this baseline.

comment:12 Changed 8 years ago by jmroot (Joshua Root)

This fails to build for me. Attaching log.

FYI, only the reporter, the owner, and the people in Cc are notified when comments are added to a ticket. So when none of those are a committer, as in this case, there's not much point asking for something to be committed by posting a comment. If you need something committed, feel free to email the macports-dev list, or ask on IRC.

Changed 8 years ago by jmroot (Joshua Root)

Attachment: cc65.log added

comment:13 Changed 8 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

It seems the makefiles don't work correctly in parallel. Committed with the addition of use_parallel_build no in r90442.

Note: See TracTickets for help on using tickets.