Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#29276 closed update (fixed)

cmus: update to 2.4.0

Reported by: devnull.macports@… Owned by: milosh@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: ryandesign (Ryan Schmidt)
Port: cmus

Description

This patch updates cmus to 2.4.0

Attachments (2)

0001-cmus-update-to-2.4.0.patch (2.3 KB) - added by devnull.macports@… 8 years ago.
0001-cmus-update-to-2.4.0.2.patch (1.2 KB) - added by devnull.macports@… 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by devnull.macports@…

comment:1 Changed 8 years ago by devnull.macports@…

Cc: devnull.macports@… added

Cc Me!

comment:2 Changed 8 years ago by devnull.macports@…

Also change CONFIG_XXX=y to CONFIG_XXX=a, to emulate autoconf behavior (don't fail if optional dependency isn't found).

comment:3 Changed 8 years ago by jmroot (Joshua Root)

Cc: devnull.macports@… removed
Keywords: haspatch added; cmus removed
Owner: changed from macports-tickets@… to milosh@…
Version: 1.9.2

Please remember to cc the maintainer. You do not need to be in cc when you are the reporter.

Are any of the dependencies not being found? Telling the configure script not to use them in that case isn't what we want; the problem needs to be fixed. Ports should use exactly what they declare dependencies on.

Also, note that the initial revision for a new version should be 0.

comment:4 Changed 8 years ago by devnull.macports@…

Thanks for all the advice! If the wanted behavior is to fail when the dependencies can't be found, 'y' is the right choice. It's just that most likely all other packages that use autoconf don't behave this way. I changed it back to 'y' and updated the patch!

Changed 8 years ago by devnull.macports@…

comment:5 in reply to:  4 Changed 8 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added
Resolution: fixed
Status: newclosed
Summary: update cmus to 2.4.0cmus: update to 2.4.0

Replying to devnull.macports@…:

If the wanted behavior is to fail when the dependencies can't be found, 'y' is the right choice. It's just that most likely all other packages that use autoconf don't behave this way.

I don't understand what you're saying. The desired behavior is for a port to declare dependencies on the other ports it uses, and for it to use the other ports it declares dependencies on. For example, cmus does not use flac and does not declare a dependency on flac, unless the flac variant is selected, in which case flac is used and a dependency is declared. This is how we want ports to work. I understand that it is common for software developers to be "helpful" and build their configure scripts so that they automatically use certain optional features if they're available and don't complain about them if they're not, but this "helpfulness" is inappropriate in MacPorts, where we want to be explicit about what other libraries are being used.

I updated the port to 2.4.0 in r78434.

comment:6 Changed 8 years ago by devnull.macports@…

Thanks for bumping the version! If this is the wanted behavior, cmus self-made configure script is perfect for MacPorts! Most (almost all?) autoconf scripts only have --enable-xxx and --disable-xxx, and in case of --enable-xxx they don't fail if "xxx" isn't available. Never mind!

Note: See TracTickets for help on using tickets.