Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#29563 closed defect (fixed)

convmv @1.14_0 renaming deletes files

Reported by: gabor.papp@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc: ryandesign (Ryan Schmidt)
Port: convmv

Description

convmv --lower --notest --replace FILE

deletes 'FILE' instead of renaming it to 'file'. I believe this is because convmv overwrites files by deleting the output file first, then renaming the input. This can cause problems on case-insensitive file systems. The attached simple patch removes file deletion before renaming.

Attachments (1)

rename.patch (499 bytes) - added by gabor.papp@… 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by gabor.papp@…

Attachment: rename.patch added

comment:1 Changed 8 years ago by ryandesign (Ryan Schmidt)

Can you please report this to the developer of convmv?

comment:2 Changed 8 years ago by gabor.papp@…

I have reported it, although it's an OS X specific problem, since the linux filesystem is case-sensitive by default.

comment:3 Changed 8 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added
Resolution: fixed
Status: newclosed

Committed a variant of your patch in r78864. Hopefully upstream will fix it for the next release.

comment:4 Changed 8 years ago by gabor.papp@…

convmv 1.15 is released with this issue fixed.

Note: See TracTickets for help on using tickets.