Opened 13 years ago
Closed 13 years ago
#29770 closed enhancement (fixed)
cmake: remove platform darwin block
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | cssdev |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | haspatch | Cc: | |
| Port: | cmake |
Description
The entire platform darwin block in the cmake port appears to no longer be needed. See r70407 (in which the platform darwin block was added to do a post-configure reinplace), r70553 (in which the universal variant was fixed by adding code to make and use a list of directories the reinplace would have to be done in), and r73737 (in which the post-configure reinplace was removed but the list-of-directories code was not deleted).
Attachments (1)
Change History (4)
Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | cmake.diff added |
|---|
comment:1 Changed 13 years ago by cssdev
| Status: | new → assigned |
|---|
I'll check the build results using otool. I need to make sure cmake doesn't pull in the wrong thing.
comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
How do you mean? The entirety of the platform darwin block is a post-configure block whose sole purpose is to set a variable called dirs, which is never used again in the portfile. I've shown above the reasons why this block came into existence, how that reason no longer exists, and how it was neglected to be removed in a previous revision. Surely it can simply be deleted now.
comment:3 Changed 13 years ago by cssdev
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
fixed in r79569
proposed patch