Opened 10 years ago

Closed 9 years ago

#29968 closed enhancement (fixed)

RFE: wireshark-devel: variants ipv6 gtk3 python

Reported by: jpo@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: hsivank@…
Port: wireshark-devel

Description

hsivank,

I have a couple of enhancements requests regarding the recent wireshark-devel update to version 1.6.0:

  • ipv6 should be on by default

IPv6 networks are more common nowadays; and its numbers are expected to increase due to the recent exhaustion of the IPv4 address space

  • libgcrypt should also be on by default

Needed by the ipsec support; also needed by capinfos to calculate the pcap files hashes (MD5, SHA1, ...)

  • missing variant: python

python scripting support (similar to the lua support)

  • missing variant: gtk3

gtk2 alternative

Thanks in advance, jpo

PS - Thanks for the 1.6.0 update

Attachments (2)

Portfile_wireshark-devel_ipv6_libgcrypt.diff (400 bytes) - added by hsivank@… 10 years ago.
Portfile_wireshark-devel_python.diff (2.3 KB) - added by hsivank@… 10 years ago.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 10 years ago by mf2k (Frank Schima)

FYI, for python support, rather than having a single "python" variant, you should create a variant for each version of python that you want to support, e.g. python26, python27, etc.

comment:2 in reply to:  1 Changed 10 years ago by jpo@…

Replying to macsforever2000@…:

FYI, for python support, rather than having a single "python" variant, you should create a variant for each version of python that you want to support, e.g. python26, python27, etc.

I forgot to mention that wireshark still does not support python 3.x.

Changed 10 years ago by hsivank@…

comment:3 Changed 10 years ago by hsivank@…

Attached a patch to add by default ip6 and libgcrypt variants

comment:4 Changed 10 years ago by hsivank@…

I use +no_x11 +quartz to build pango and gtk. It seems that gtk3 is not ready on osx : #29063
Anyway, need to rebuild my ports ...

comment:5 Changed 10 years ago by hsivank@…

Attached a patch to add python26 and python27 variants

comment:6 Changed 10 years ago by hsivank@…

Jpo, wireshark 1.6.0 is not ready to build with gtk3 ( portage is not finished yet http://wiki.wireshark.org/GoingGTK3 )

This is the variant i use to test

variant gtk3 conflicts no_gui {
        depends_lib-delete      port:gtk2
        depends_lib-append      port:gtk3
        configure.args-append   --with-gtk3
}

comment:7 in reply to:  3 Changed 10 years ago by jpo@…

Replying to hsivank@…:

Attached a patch to add by default ip6 and libgcrypt variants

+1

comment:8 in reply to:  5 ; Changed 10 years ago by jpo@…

Replying to hsivank@…:

Attached a patch to add python26 and python27 variants

A build with "sudo port install wireshark-devel +libsmi +lua +python27" finishes and installs correctly but I get spurious output even when running "tshark -v":

$ tshark -v
dlopen(libwireshark.dylib, 6): image not found
[Errno 2] No such file or directory: '/opt/local/lib/wireshark/python/2.7/wspy_dissectors'
TShark 1.6.0 (SVN Rev Unknown from unknown)

Copyright 1998-2011 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GLib 2.28.8, with libpcap 1.1.1, with libz 1.2.5, without
POSIX capabilities, without libpcre, with SMI 0.4.8, with c-ares 1.7.4, with Lua
5.1, with Python, without GnuTLS, with Gcrypt 1.4.6, with MIT Kerberos, without
GeoIP.

Running on Mac OS 10.6.8 (Darwin 10.8.0), with libpcap version 1.1.1, with libz
1.2.5.

Built using gcc 4.2.1 (Apple Inc. build 5666) (dot 3).

Looking into it [1] ...

jpo

[1] - http://wiki.wireshark.org/Python

comment:9 in reply to:  8 Changed 10 years ago by jpo@…

Replying to jpo@…:

[Errno 2] No such file or directory: '/opt/local/lib/wireshark/python/2.7/wspy_dissectors'

The subdirectory wspy_dissectors wasn't automatically created.

The above error message disappeared when I manually created it:

cd /opt/local/lib/wireshark/python/2.7
sudo mkdir wspy_dissectors

comment:10 Changed 10 years ago by hsivank@…

Uploaded a new patch to fix wspy_dissectors directory bug.
It remains a problem with :

$ tshark -v
dlopen(libwireshark.dylib, 6): image not found

comment:11 Changed 10 years ago by hsivank@…

add support for python25 + small fix

comment:12 Changed 10 years ago by hsivank@…

fix dlopen bug + factorization.

comment:13 Changed 10 years ago by hsivank@…

fix python include / library detection

comment:14 Changed 10 years ago by jpo@…

The wspy_dissectors subdirectory creation should have been solved upstream and hopefully in time for the 1.6.1 and 1.4.8 Wireshark releases.

Links:

comment:15 Changed 10 years ago by jpo@…

Another missing variant:

  • geoip (requires port libgeoip)

comment:16 Changed 10 years ago by jpo@…

hsivank,

The just released wireshark 1.6.1 no longer prints a warning if the wspy_dissectors directory doesn't exists.

With the following post-destroot block commented

if {[variant_isset python25] || [variant_isset python26] || [variant_isset python27]} {
...
}

only four files are installed in /opt/local/lib/wireshark/python/1.6.1/ (no wspy_dissectors subdirectory)

$ ls /opt/local/lib/wireshark/python/1.6.1/
homeplug.py.sample  register-dissector.py  wspy_dissector.py  wspy_libws.py

and 'tshark -v' produces the following output

$ tshark -v
dlopen(libwireshark.dylib, 6): image not found
TShark 1.6.1 (SVN Rev Unknown from unknown)

Copyright 1998-2011 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GLib 2.28.8, with libpcap 1.1.1, with libz 1.2.5, without
POSIX capabilities, without libpcre, with SMI 0.4.8, with c-ares 1.7.4, with Lua
5.1, with Python, without GnuTLS, with Gcrypt 1.5.0, with MIT Kerberos, without
GeoIP.

Running on Mac OS 10.6.8 (Darwin 10.8.0), with libpcap version 1.1.1, with libz
1.2.5.

Built using gcc 4.2.1 (Apple Inc. build 5666) (dot 3).

comment:17 Changed 10 years ago by jpo@…

The upstream fix regarding the wspy_dissectors subdirectory is still incomplete as they only avoid printing the warning if it doesn't exists (they still don't create it during the installation process, the user will have to do it manually).

Upstream fix:

comment:18 in reply to:  16 Changed 10 years ago by hsivank@…

Replying to jpo@…:

With the following post-destroot block commented

if {[variant_isset python25] || [variant_isset python26] || [variant_isset python27]} {
...
}

and 'tshark -v' produces the following output

$ tshark -v
dlopen(libwireshark.dylib, 6): image not found

This commented lines contain a fix for "dlopen(libwireshark.dylib, 6): image not found" : Python interpreter is not correct

reinplace "s|libwireshark.dylib|${prefix}/lib/libwireshark.dylib|g" ${worksrcpath}/epan/wspython/wspy_libws.py

Changed 10 years ago by hsivank@…

comment:19 Changed 10 years ago by hsivank@…

wspy_dissectors just contains a sample example (homeplug.py.sample). it could be placed into the same directory of wspy_libws.py without problems ...

uploaded a new patch for wireshark 1.6.1 ( wspy_dissectors folder is not created ) + created a new ticket for wireshark 1.6.1 #30230

comment:20 Changed 9 years ago by jpo@…

Hi,

This ticket can be closed (the pending requests were moved to ticket #32265).

/jpo

comment:21 Changed 9 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed

Closing per last comment.

Note: See TracTickets for help on using tickets.