Opened 13 years ago

Closed 12 years ago

#30036 closed defect (fixed)

mcpp @2.7.2 patch for comments on end of line

Reported by: n.a.hawes@… Owned by: blair (Blair Zajac)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc: andrew.edem@…
Port: mcpp

Description

mcpp 2.7.2 omits lines that have a comment on the end. This causes problems for ZeroC Ice as described here: http://www.zeroc.com/forums/bug-reports/5309-mishap-slice-compilers.html. ZeroC have patched mcpp, and it appears that the port contains some of these patches but not all of them. Unfortunately all the patches have been rolled into a single patch file, which I have attached (from the third party source archive http://www.zeroc.com/download.html#src). Perhaps it's easiest to replace the existing patches with this?

Attachments (2)

patch.mcpp.2.7.2 (6.6 KB) - added by n.a.hawes@… 13 years ago.
ZeroC's patch for mcpp 2.7.2
patch-mcpp-comment-parsing-fix (1.1 KB) - added by andrew.edem@… 12 years ago.
Patch for MCPP 2.7.2 to fix comment parsing problem

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by n.a.hawes@…

Attachment: patch.mcpp.2.7.2 added

ZeroC's patch for mcpp 2.7.2

comment:1 Changed 13 years ago by jmroot (Joshua Root)

Cc: blair removed
Owner: changed from macports-tickets@… to blair@…

Bare usernames do not work in the Cc field; you have to use complete email addresses.

comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: andrew.edem@… added
Keywords: haspatch added

Has duplicate #30036 which has a different patch (only part of the patch attached here).

Changed 12 years ago by andrew.edem@…

Patch for MCPP 2.7.2 to fix comment parsing problem

comment:3 Changed 12 years ago by andrew.edem@…

I attached a single patch to the ticket that fixes the comment parsing problem. This is a subset of the larger ZeroC patch which was not included with the port. (The other patches are already there.)

I've already tested it and it compiles correctly and fixes the problems with the ice-python, which is basically non-functional right now due to this issue.

comment:4 Changed 12 years ago by freebsd@…

I agree with Andrew, placing https://trac.macports.org/attachment/ticket/30036/patch-mcpp-comment-parsing-fix in /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/devel/mcpp/files/ works and should be committed to macports.

comment:5 in reply to:  description Changed 12 years ago by freebsd@…

Is Blair actually still maintaining this port or should we consider this abandoned? (the original patch was sent 6 months ago, Andrew sent a refined and easier to apply version 1 month ago).

comment:6 Changed 12 years ago by blair (Blair Zajac)

Resolution: fixed
Status: newclosed

Fixed in r89236 with other cleanup commits in r89235 and r89237.

Note: See TracTickets for help on using tickets.