Opened 8 years ago

Closed 7 years ago

#30462 closed defect (fixed)

Valgrind 3.6.1 fails to build on Lion

Reported by: jamesfmarshall@… Owned by: raimue (Rainer Müller)
Priority: Normal Milestone:
Component: ports Version: 2.0.0
Keywords: lion Cc: evandrix (Lee Wei Yeong), erkinbah@…, cdeil (Christoph Deil), nils.hjelte@…, thomas.bonfort@…, axeljaeger@…, maehne (Torsten Maehne)
Port: valgrind

Description

I received the "Error: Target org.macports.configure returned: configure failure: shell command failed (see log for details)."

The main.log is attached.

Attachments (4)

main.log (12.7 KB) - added by jamesfmarshall@… 8 years ago.
main.log for failed build of Valgrind 3.6.1 on Lion
patch-lion-configure.diff (654 bytes) - added by dean.povey@… 8 years ago.
Patch to configure.in for Lion support
patch-valgrind-portfile.diff (887 bytes) - added by dean.povey@… 8 years ago.
Patch to valgrind portfile to support lion
upstream_58577.diff (21.0 KB) - added by barry.allard@… 7 years ago.
Upstream "proposed patch (21.05 KB, patch)" http://bugsfiles.kde.org/attachment.cgi?id=58577

Download all attachments as: .zip

Change History (23)

Changed 8 years ago by jamesfmarshall@…

Attachment: main.log added

main.log for failed build of Valgrind 3.6.1 on Lion

comment:1 Changed 8 years ago by jamesfmarshall@…

Cc: jamesfmarshall@… added

Cc Me!

comment:2 Changed 8 years ago by ryandesign (Ryan Schmidt)

Cc: raimue@… jamesfmarshall@… removed
Keywords: lion added; Lion Valgrind removed
Owner: changed from macports-tickets@… to raimue@…
Port: valgrind added; Valgrind 3.6.1 removed

Yup, the log says:

error: Valgrind works on Darwin 9.x and 10.x (Mac OS X 10.5 and 10.6)

comment:3 Changed 8 years ago by ryandesign (Ryan Schmidt)

Summary: Valgrind 3.6.1 fails to build on Lion with MacPorts 2.0.0Valgrind 3.6.1 fails to build on Lion

comment:4 Changed 8 years ago by raimue (Rainer Müller)

Status: newassigned

I added a check to the Portfile to reflect this fact in r81374.

See also the upstream bug report.

comment:5 Changed 8 years ago by dean.povey@…

I put together a patch to work around this based on this snippet:

https://gist.github.com/1117049/28aec833558f4a680d336522f5e2d1493a59e003

See attached Portfile and configure.in patch. It seems to work fine.

Changed 8 years ago by dean.povey@…

Attachment: patch-lion-configure.diff added

Patch to configure.in for Lion support

Changed 8 years ago by dean.povey@…

Patch to valgrind portfile to support lion

comment:6 Changed 8 years ago by raimue (Rainer Müller)

Of course you can patch the configure script, but that will not magically implement support for Lion. You will not get any usable result from valgrind with this patch due to unhandled syscalls. I am not going to apply this patch as it would imply the valgrind port supports Lion.

comment:7 Changed 8 years ago by matthew.g.russell@…

Cc: matthew.g.russell@… added

Cc Me!

comment:8 Changed 8 years ago by evandrix (Lee Wei Yeong)

Cc: evandrix@… added

Cc Me!

comment:9 Changed 8 years ago by erkinbah@…

Cc: erkinbah@… added

Cc Me!

comment:10 Changed 8 years ago by cdeil (Christoph Deil)

Cc: Deil.Christoph@… added

Cc Me!

comment:11 Changed 8 years ago by nils.hjelte@…

Cc: nils.hjelte@… added

Cc Me!

comment:12 Changed 8 years ago by thomas.bonfort@…

Cc: thomas.bonfort@… added

Cc Me!

comment:13 Changed 7 years ago by axeljaeger@…

Cc: axeljaeger@… added

Cc Me!

comment:14 Changed 7 years ago by matthew.g.russell@…

Cc: matthew.g.russell@… removed

Cc Me!

comment:15 Changed 7 years ago by barry.allard@…

I encountered this exact issue on MP 2.0.3 latest port tree on 10.7.2. It seems something needs to be tried before blessed as production, but that's a bit of a catch-22. Could this be placed in a topical dev branch or something?

Changed 7 years ago by barry.allard@…

Attachment: upstream_58577.diff added

Upstream "proposed patch (21.05 KB, patch)" http://bugsfiles.kde.org/attachment.cgi?id=58577

comment:16 in reply to:  15 Changed 7 years ago by barry.allard@…

Replying to barry.allard@…:

I encountered this exact issue on MP 2.0.3 latest port tree on 10.7.2. It seems something needs to be tried before blessed as production, but that's a bit of a catch-22. Could this be placed in a topical dev branch or something?

I hear ./autogen.sh, ./configure ..., make install may appear to work as well as snow leopard with another upstream patch <<just attached to ticket>> from https://bugs.kde.org/show_bug.cgi?id=267997

comment:17 Changed 7 years ago by maehne (Torsten Maehne)

Cc: Torsten.Maehne@… added

Cc Me!

comment:18 Changed 7 years ago by ryandesign (Ryan Schmidt)

#32028 provides a patch to update valgrind to 3.7.0 which is apparently Lion-compatible.

comment:19 Changed 7 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: assignedclosed

Fixed by the update to valgrind @3.7.0 in r87183.

Note: See TracTickets for help on using tickets.