Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#32149 closed submission (fixed)

Portfile for installing bbdb

Reported by: vishketan@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: Cc:
Port: bbdb

Description

Please find attached.

Attachments (3)

Portfile (2.7 KB) - added by vishketan@… 7 years ago.
Portfile for bbdb
Portfile.2 (2.9 KB) - added by vishketan@… 7 years ago.
Updated to fix comments and suggestions.
Portfile.3 (3.2 KB) - added by vishketan@… 7 years ago.
Checksums changed

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by vishketan@…

Attachment: Portfile added

Portfile for bbdb

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Port: bbdb added
Status: newassigned

Thanks. Some comments:

  • The whitespace should conform to the modeline: spaces, not tabs, for indents; you should also align things into columns -- in many Portfiles, the 2nd column begins at the 20th character
  • There should be a newline after the "PortSystem" line, and there should be no trailing whitespace; see "port lint --nitpick"
  • Since you are not a committer, the "maintainers" line must be your complete valid email address, preferably in our obfuscated form (domain:user)
  • More than one checksum type should be used for each distfile; rmd160 and sha256 are recommended
  • The checksum you supplied doesn't match the checksum of the file MacPorts downloaded for me; the file hasn't changed on SourceForge since 2007 so I'm not sure what file's checksum you listed; I'll change it to the checksums I'm getting
  • The "--prefix" argument goes in configure.pre_args, not configure.args
  • Instead of "ui_msgs" in post-activate, use "notes"
  • SourceForge master_sites should be written more specifically, to avoid redirects
  • "distname bbdb-${version}" is the default, so it's redundant
  • The descriptions of variants should be worded as if they were checkbox or radio button labels
  • Files should be installed with permission so that regular users can read them (644 instead of 640)

comment:2 Changed 7 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

Added port in r87413 with the above changes.

comment:3 Changed 7 years ago by ryandesign (Ryan Schmidt)

Oh yes, and I added a "license" line, based on the comment headers in the source files themselves.

Changed 7 years ago by vishketan@…

Attachment: Portfile.2 added

Updated to fix comments and suggestions.

Changed 7 years ago by vishketan@…

Attachment: Portfile.3 added

Checksums changed

comment:4 Changed 7 years ago by vishketan@…

The install fails on my machine with checksum failure. I have updated a version with the checksums. Please have a look.

Note: See TracTickets for help on using tickets.