Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#32304 closed update (fixed)

openconnect new version 3.15 - portfile update

Reported by: florian@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc:
Port: openconnect

Description

openconnect 3.15 resolves several NLS related bugs. I added a new variant +nls and removed the build dependency port:intltool.

Attachments (1)

Portfile.patch (2.0 KB) - added by florian@… 7 years ago.
portfile patch

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by florian@…

Attachment: Portfile.patch added

portfile patch

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks.

comment:2 Changed 7 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

Updated in r87616. There's no reason to have gettext support in a variant; I enabled it all the time.

comment:3 Changed 7 years ago by florian@…

If that is so, you can remove the nls variants of these ports as well:

  • editors/MacVim
  • editors/vim-app
  • editors/vim
  • mail/gnupg12
  • net/gajim
  • textproc/aspell
  • x11/icewm

Btw, are there any guidelines for creating variants and when not to do so? Thanks for the quick update!

comment:4 in reply to:  3 ; Changed 7 years ago by ryandesign (Ryan Schmidt)

Replying to florian@…:

If that is so, you can remove the nls variants of these ports as well:

  • editors/MacVim
  • editors/vim-app
  • editors/vim

I agree. I filed #32332 for this.

  • mail/gnupg12

I agree. This port needs several other updates as well. I filed #32330 for this.

  • net/gajim

gajim doesn't have a nls variant -- it has a nonls variant which disables natural language support. I agree there's no reason for it to have this variant and filed ticket #32324 requesting its removal.

  • textproc/aspell

The aspell port says:

platform macosx {
# gnustep-gui uses aspell and will not work if aspell is linked to gettext because
# gettext is linked to CoreFoundation which is itself linked to the Apple objc runtime
    if { ![variant_isset nls] } {
        default_variants        +nonls
    }
}

so it sounds like it's not a good idea to enable nls for aspell.

  • x11/icewm

The description of the variant there says "Use internationalized messages (does not work correct yet)" so I don't think it's a good idea to enable nls for icewm.

Btw, are there any guidelines for creating variants and when not to do so? Thanks for the quick update!

Ports should usually include as much functionality as possible without the need to select variants. Make a variant if the feature is esoteric (i.e. few users would want it), or has undesirable side effects, or has many dependencies or large dependencies that take a long time to build. gettext is an extremely common library that will almost definitely be on all users' systems already. (gettext is a library dependency of glib2, which is a library dependency of pkgconfig, which is a build dependency of a majority of ports (including openconnect)).

comment:5 in reply to:  4 Changed 7 years ago by florian@…

Replying to ryandesign@…:

  • textproc/aspell

The aspell port says:

platform macosx {
# gnustep-gui uses aspell and will not work if aspell is linked to gettext because
# gettext is linked to CoreFoundation which is itself linked to the Apple objc runtime
    if { ![variant_isset nls] } {
        default_variants        +nonls
    }
}

so it sounds like it's not a good idea to enable nls for aspell.

  • x11/icewm

The description of the variant there says "Use internationalized messages (does not work correct yet)" so I don't think it's a good idea to enable nls for icewm.

Sorry, I just grepped the portfiles for nls variants and did not check any details.

Btw, are there any guidelines for creating variants and when not to do so? Thanks for the quick update!

Ports should usually include as much functionality as possible without the need to select variants. Make a variant if the feature is esoteric (i.e. few users would want it), or has undesirable side effects, or has many dependencies or large dependencies that take a long time to build. gettext is an extremely common library that will almost definitely be on all users' systems already. (gettext is a library dependency of glib2, which is a library dependency of pkgconfig, which is a build dependency of a majority of ports (including openconnect)).

Right, the argumentation makes sense. On the other hand, it seems to be a matter of personal taste where to draw the line. Btw: there are bzip2 variants, even though bzip2 is probably more common than gettext and unlike gettext has no dependencies at all.

Note: See TracTickets for help on using tickets.