Opened 13 years ago

Closed 7 years ago

#32376 closed submission (fixed)

x48 port submission

Reported by: mklein-de (Michael Klein) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mf2k (Frank Schima), aldurbano
Port: x48

Description

This emulator is capable of providing a faithful replication of the HP48. It also has a debugger for the saturn processor.

Attachments (6)

Portfile (2.8 KB) - added by mklein-de (Michael Klein) 13 years ago.
main.log (46.7 KB) - added by mf2k (Frank Schima) 7 years ago.
Portfile.2 (2.9 KB) - added by mf2k (Frank Schima) 7 years ago.
Here is my updated version of the Portfile
Portfile.3 (3.0 KB) - added by mklein-de (Michael Klein) 7 years ago.
updated updated Portfile
patch-src-debugger.c.diff (272 bytes) - added by mklein-de (Michael Klein) 7 years ago.
first patch
patch-src-emulate.c.diff (469 bytes) - added by mklein-de (Michael Klein) 7 years ago.
second patch

Download all attachments as: .zip

Change History (17)

Changed 13 years ago by mklein-de (Michael Klein)

Attachment: Portfile added

comment:1 Changed 7 years ago by mf2k (Frank Schima)

Sorry for the delay. I just started looking at this.

Some questions:

  • Are you still interested in maintaining?
  • Why not always download the ROMs? Does that change the license?

comment:2 Changed 7 years ago by mf2k (Frank Schima)

Cc: mf2k added

comment:3 Changed 7 years ago by mf2k (Frank Schima)

Version: 2.0.3

comment:4 Changed 7 years ago by mf2k (Frank Schima)

Cc: aldurbano added

Has duplicate #54224.

comment:5 in reply to:  1 Changed 7 years ago by mklein-de (Michael Klein)

Replying to mf2k:

Sorry for the delay. I just started looking at this.

Some questions:

  • Are you still interested in maintaining?

sure, can do that

  • Why not always download the ROMs? Does that change the license?

that is quite possible, as the emulator itself is GPL.

comment:6 Changed 7 years ago by mf2k (Frank Schima)

So my latest error with the +roms variant is in extract. Does this work for you?

$ sudo port build
--->  Computing dependencies for x48
--->  Fetching distfiles for x48
--->  Attempting to fetch x48-0.6.4.tar.bz2 from http://cytranet.dl.sourceforge.net/x48.berlios
--->  Attempting to fetch gxrom-r.bz2 from http://cytranet.dl.sourceforge.net/x48.berlios
--->  Attempting to fetch sxrom-j.bz2 from http://cytranet.dl.sourceforge.net/x48.berlios
--->  Verifying checksums for x48
--->  Extracting x48
Error: Failed to extract x48: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_github.com_macports_macports-ports_emulators_x48/x48/main.log for details.

I will attach the complete log.

Last edited 7 years ago by mf2k (Frank Schima) (previous) (diff)

Changed 7 years ago by mf2k (Frank Schima)

Attachment: main.log added

Changed 7 years ago by mf2k (Frank Schima)

Attachment: Portfile.2 added

Here is my updated version of the Portfile

comment:7 in reply to:  6 ; Changed 7 years ago by mklein-de (Michael Klein)

Replying to mf2k:

So my latest error with the +roms variant is in extract. Does this work for you?

it works with the original Portfile and fails with the updated Portfile

In the updated Portfile the following line is commented out:

extract.only    ${distname}${extract.suffix}

After adding this again it fails now in build:

--->  Building x48
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_a98.shuttle.de_dports_emulators_x48/x48/work/." && /usr/bin/make -j4 -w all
make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_a98.shuttle.de_dports_emulators_x48/x48/work'
/Applications/Xcode.app/Contents/Developer/usr/bin/make  all-recursive
make[1]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_a98.shuttle.de_dports_emulators_x48/x48/work'
Making all in src
make[2]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_a98.shuttle.de_dports_emulators_x48/x48/work/src'
/usr/bin/clang -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include  -pipe -Os -arch x86_64 -MT actions.o -MD -MP -MF .deps/actions.Tpo -c -o actions.o actions.c
/usr/bin/clang -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include  -pipe -Os -arch x86_64 -MT debugger.o -MD -MP -MF .deps/debugger.Tpo -c -o debugger.o debugger.c
/usr/bin/clang -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include  -pipe -Os -arch x86_64 -MT device.o -MD -MP -MF .deps/device.Tpo -c -o device.o device.c
/usr/bin/clang -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include  -pipe -Os -arch x86_64 -MT disasm.o -MD -MP -MF .deps/disasm.Tpo -c -o disasm.o disasm.c
debugger.c:1575:39: warning: format specifies type 'void *' but the argument has type 'word_20' (aka 'long') [-Wformat]
      printf("%d %p -> [%s] %s\n", i, ent, typ, dat);
                 ~~                   ^~~
                 %ld
mv -f .deps/device.Tpo .deps/device.Po
debugger.c:1582:39: warning: format specifies type 'void *' but the argument has type 'word_20' (aka 'long') [-Wformat]
      printf("%d %p -> [%s] %s\n", i, ent, typ, dat);
                 ~~                   ^~~
                 %ld
debugger.c:1588:3: error: non-void function 'get_stack' should return a value [-Wreturn-type]
  return;
  ^
2 warnings and 1 error generated.
/usr/bin/clang -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include  -pipe -Os -arch x86_64 -MT emulate.o -MD -MP -MF .deps/emulate.Tpo -c -o emulate.o emulate.c
make[2]: *** [debugger.o] Error 1
make[2]: *** Waiting for unfinished jobs....

comment:8 in reply to:  7 Changed 7 years ago by mklein-de (Michael Klein)

ok, I also have two small patches for clang here ;-)

Changed 7 years ago by mklein-de (Michael Klein)

Attachment: Portfile.3 added

updated updated Portfile

Changed 7 years ago by mklein-de (Michael Klein)

Attachment: patch-src-debugger.c.diff added

first patch

Changed 7 years ago by mklein-de (Michael Klein)

Attachment: patch-src-emulate.c.diff added

second patch

comment:9 Changed 7 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed

comment:10 Changed 7 years ago by aldurbano

Resolution: fixed
Status: closedreopened

the functionality with keyboard is working. Tapping on the calculators keys with the trackpad not. To get a response the trackpad must *clicked*, pushed down. Would be possible adding the capability to react on tapping on the trackpad?

comment:11 Changed 7 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: reopenedclosed

Please do not re-open this ticket because the port has been added to Macports. Instead open a new ticket for this port with your enhancement request.

Note: See TracTickets for help on using tickets.