Opened 12 years ago

Closed 10 years ago

#32590 closed update (fixed)

lua port update

Reported by: andremm@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc: ryandesign (Ryan Carsten Schmidt), anddam (Andrea D'Amore), lperry (Perry Lee), mojca (Mojca Miklavec)
Port: lua

Description

Lua 5.2.0 is out since Dec 16th. For this reason I'm providing an updated Portfile to lua port, as well as the necessary patches and files.

To my mind, a new port called lua51 should be created with current lua Portfile for Lua 5.1.4.

Regards, Andre

Attachments (5)

Portfile (2.7 KB) - added by andremm@… 12 years ago.
lua.pc (657 bytes) - added by andremm@… 12 years ago.
patch-Makefile.diff (689 bytes) - added by andremm@… 12 years ago.
patch-src_Makefile.diff (1.6 KB) - added by andremm@… 12 years ago.
lua.diff (13.4 KB) - added by andremm@… 12 years ago.

Download all attachments as: .zip

Change History (16)

Changed 12 years ago by andremm@…

Attachment: Portfile added

Changed 12 years ago by andremm@…

Attachment: lua.pc added

Changed 12 years ago by andremm@…

Attachment: patch-Makefile.diff added

Changed 12 years ago by andremm@…

Attachment: patch-src_Makefile.diff added

comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Port: lua added

Please supply a diff of your Portfile changes. I can already see that the conflicts line should not contain commas.

A lua51 port would fit in with our existing lua50 port. But I wouldn't recommend making one, unless we think someone actually needs this. (Does anyone need the lua50 port?)

Changed 12 years ago by andremm@…

Attachment: lua.diff added

comment:2 in reply to:  1 Changed 12 years ago by andremm@…

I added lua.diff. It is the diff with all changes I did.

Please, notice that I removed the comma from conflicts and left conflicts only with lua51.

Replying to ryandesign@…:

Please supply a diff of your Portfile changes. I can already see that the conflicts line should not contain commas.

A lua51 port would fit in with our existing lua50 port. But I wouldn't recommend making one, unless we think someone actually needs this. (Does anyone need the lua50 port?)

comment:3 Changed 12 years ago by wmacgyver@…

any movement on this?

comment:4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added

Quickly glancing at the lua.diff, the $Id$ line should not be removed.

We either want numbered lua ports (lua50, lua51, lua52) and for them not to conflict with one another (i.e. for them to install files in separate directories or with non-conflicting names), or for there to just be a single lua port with the latest version. The current situation with lua and lua50 ports that conflict is an error that should not be perpetuated. The decision about which path to follow depends on whether there's a reason anyone would want older versions of lua.

comment:5 Changed 12 years ago by anddam (Andrea D'Amore)

Cc: and.damore@… added

Cc Me!

comment:6 Changed 12 years ago by anddam (Andrea D'Amore)

Cc: perry@… added

perry, is there a reason to have an explicit lua50 rather than lua port dependency like in elinks-devel port?

comment:7 Changed 12 years ago by lperry (Perry Lee)

It's been awhile, but iirc, newer versions of elinks don't properly detect lua > 5.0.x, which is why elinks-devel should use lua50.

If there are other ports that similarly don't work properly with lua 5.1.x, maybe we should go with numbered lua ports?

-> % port installed elinks-devel
The following ports are currently installed:
  elinks-devel @0.12pre5_1+colors+lua (active)

With lua:

-> % otool -L `which elinks`
/opt/local/bin/elinks:
        /opt/local/lib/libtre.5.dylib (compatibility version 6.0.0, current version 6.0.0)
        /opt/local/lib/libintl.8.dylib (compatibility version 10.0.0, current version 10.1.0)
        /opt/local/lib/libiconv.2.dylib (compatibility version 8.0.0, current version 8.1.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 169.3.0)
        /opt/local/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
        /opt/local/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
        /opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.7)
        /opt/local/lib/libbz2.1.0.dylib (compatibility version 1.0.0, current version 1.0.6)
        /opt/local/lib/libidn.11.dylib (compatibility version 18.0.0, current version 18.8.0)
        /opt/local/lib/libexpat.1.dylib (compatibility version 8.0.0, current version 8.0.0)
        /opt/local/lib/libjs.dylib (compatibility version 0.0.0, current version 0.0.0)

With lua50:

-> % otool -L `which elinks`            
/opt/local/bin/elinks:
        /opt/local/lib/libtre.5.dylib (compatibility version 6.0.0, current version 6.0.0)
        /opt/local/lib/libintl.8.dylib (compatibility version 10.0.0, current version 10.1.0)
        /opt/local/lib/libiconv.2.dylib (compatibility version 8.0.0, current version 8.1.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 169.3.0)
        /opt/local/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
        /opt/local/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
        /opt/local/lib/liblua.5.0.dylib (compatibility version 5.0.0, current version 5.0.0)
        /opt/local/lib/liblualib.5.0.dylib (compatibility version 5.0.0, current version 5.0.0)
        /opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.7)
        /opt/local/lib/libbz2.1.0.dylib (compatibility version 1.0.0, current version 1.0.6)
        /opt/local/lib/libidn.11.dylib (compatibility version 18.0.0, current version 18.8.0)
        /opt/local/lib/libexpat.1.dylib (compatibility version 8.0.0, current version 8.0.0)
        /opt/local/lib/libjs.dylib (compatibility version 0.0.0, current version 0.0.0)

comment:8 Changed 12 years ago by slewsys (Andrew L. Moore)

I duplicated the work here on Ticket #34830. andremm@… included a lua.pc which I've added along with updated Portfile and patches for lua 5.2.1. The updates were posted to #34830 to avoid confusion.

NB: Lua 5.2 breaks many packages, so it is not suitable as a lua port replacement.

comment:9 Changed 10 years ago by mojca (Mojca Miklavec)

Cc: mojca@… added

Cc Me!

comment:10 Changed 10 years ago by mojca (Mojca Miklavec)

Why is this ticket still open?

comment:11 Changed 10 years ago by anddam (Andrea D'Amore)

Resolution: fixed
Status: newclosed

Because nobody closed it.

Since lua is @5.2.3 and a lua51 port has been provided as well this can be safely closed.

Note: See TracTickets for help on using tickets.