Opened 9 years ago

Closed 8 years ago

#32694 closed defect (fixed)

subversion-perlbindings: Perl version used is dependent on perl5 variant

Reported by: larryv (Lawrence Velázquez) Owned by: danielluke (Daniel J. Luke)
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: Cc: danielluke (Daniel J. Luke), blair (Blair Zajac)
Port: subversion-perlbindings

Description

Seems like my having perl5 +perl5_14 installed brings out a lot of edge cases.

Installing p5.12-svn-simple fails if subversion-perlbindings was built with something other than Perl 5.12. This happened to me because I have perl5 +perl5_14 installed. I assume the same problem crops up with other non-matching combinations.

Can subversion-perlbindings not be split into subports?

Attachments (1)

subversion-perlbindings-subports.diff (2.0 KB) - added by jmroot (Joshua Root) 8 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 9 years ago by danielluke (Daniel J. Luke)

Resolution: invalid
Status: newclosed

Do you have a log of the problem? subversion-perlbindings doesn't depend on p5-svn-simple (it depends on perl5). p5-svn-simple uses the perl5 port group (and so, also uses subports) so there is a p5.14-svn-simple that is more likely to be what you want.

I'm going to close this for now (as installing a p5.12 port when you have perl5.14 installed is going to 'look weird'). Please re-open with a description of the actual issue and a log of the problem.

comment:2 Changed 9 years ago by larryv (Lawrence Velázquez)

Resolution: invalid
Status: closedreopened

Sorry, I didn't explain this very well at all.

I was installing git-core +svn, which is dependent on p5.12-svn-simple, which is dependent on subversion-perlbindings, which is dependent on perl5. Since I have perl5 +perl5_14 installed, subversion-perlbindings gets installed under Perl 5.14. Then p5.12-svn-simple can't find the Subversion bindings.

Switching to perl5 +perl5_12 temporarily is an easy fix, but this seems clumsy. Is there a reason that subversion-perlbindings doesn't have subports so it can be installed correctly in dependency chains such as this, without fiddling with the variant of perl5? For instance, p5.12-svn-simple would be dependent on p5.12-subversion-bindings or something, and that would install under Perl 5.12 regardless of what perl5 variant is present.

comment:3 Changed 9 years ago by danielluke (Daniel J. Luke)

Owner: changed from macports-tickets@… to dluke@…
Status: reopenednew

Oh, that makes some sense.

I think the 'correct' fix in this case is to fix git-core, though (so you don't have to have 2 perls installed just because you are running 5.14 normally and git-core depends only on 5.12

The reason why subversion-perlbindings doesn't have subports (or variants for specific perls) is just that no one has done it yet (and no one has asked, until now.)

comment:4 Changed 9 years ago by larryv (Lawrence Velázquez)

Seems like MacPorts has been moving away from that, though. See r82553.

Heh, I guess if no one's ever asked for subversion-perlbindings subports, no one must be having issues (except me!). I'll probably look into it myself then, when I have a little time.

comment:5 Changed 8 years ago by jmroot (Joshua Root)

That commit wasn't about moving away from allowing different perls to be used, it was about being able to tell which perl you are using. Maintainers are free to add variants or subports as appropriate if support for multiple perl versions is desired.

Changed 8 years ago by jmroot (Joshua Root)

comment:6 Changed 8 years ago by jmroot (Joshua Root)

The attached patch adds subports so other ports can depend on the perl bindings for a specific perl version.

comment:7 in reply to:  6 Changed 8 years ago by danielluke (Daniel J. Luke)

Replying to jmr@…:

The attached patch adds subports so other ports can depend on the perl bindings for a specific perl version.

jmr, You have my blessing to commit this now, otherwise I will try to look at it later today.

comment:8 Changed 8 years ago by danielluke (Daniel J. Luke)

has duplicate #35660

comment:9 Changed 8 years ago by danielluke (Daniel J. Luke)

I'm running through the subversion testsuite now for 1.7.6 and am planning on including this change with my testing (and the update).

comment:10 in reply to:  9 Changed 8 years ago by danielluke (Daniel J. Luke)

Resolution: fixed
Status: newclosed

Replying to dluke@…:

planning on including this change with my testing (and the update).

r96665

Note: See TracTickets for help on using tickets.