Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#33311 closed defect (fixed)

ISC DHCP 3.1-ESV is End-of-Life on March 1st, 2012

Reported by: stefan.van.der.eijk@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: Cc: neverpanic (Clemens Lang)
Port: dhcp

Description

See: https://www.isc.org/announcement/isc-dhcp-31-esv-end-life-march-1st-2012

Is the DHCP in macports going to be updated to a version that will receive security updates?

Attachments (4)

Portfile.diff (1.0 KB) - added by stefan.van.der.eijk@… 12 years ago.
RFC3542.include.patch (312 bytes) - added by stefan.van.der.eijk@… 12 years ago.
main.log (42.9 KB) - added by stefan.van.der.eijk@… 12 years ago.
Portfile.4.1-ESV-R4.diff (1.4 KB) - added by stefan.van.der.eijk@… 12 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 12 years ago by mf2k (Frank Schima)

This port is out of date, but it has no maintainer. Supplying a tested patch to update it would be helpful.

Changed 12 years ago by stefan.van.der.eijk@…

Attachment: Portfile.diff added

Changed 12 years ago by stefan.van.der.eijk@…

Attachment: RFC3542.include.patch added

Changed 12 years ago by stefan.van.der.eijk@…

Attachment: main.log added

comment:2 in reply to:  1 Changed 12 years ago by stefan.van.der.eijk@…

Replying to macsforever2000@…:

This port is out of date, but it has no maintainer. Supplying a tested patch to update it would be helpful.

:-)

I found it easier said than done. I've attached the changes I've made to the port file, a patch I created and the output of the build. I'm now stuck with some Undefined symbols that I don't know how to deal with.

comment:3 Changed 12 years ago by neverpanic (Clemens Lang)

Cc: cal@… added
Keywords: clang added

This is probably yet another case of http://clang.llvm.org/compatibility.html#inline. Possible fixes:

  • set configure.compiler to llvm-gcc-4.2 if it's clang (the least favorable solution)
  • add -std=c89 to configure.cflags if compiling with clang
  • patch the code to drop the inline from the function declaration (imho the best solution here)

Also, if it turns out the problem was caused by this you might want to report it back to upstream for assuming to be compiled against the GNU 89 standard without actually specifying a standard.

comment:4 in reply to:  3 Changed 12 years ago by stefan.van.der.eijk@…

Replying to cal@…:

This is probably yet another case of http://clang.llvm.org/compatibility.html#inline. Possible fixes:

  • set configure.compiler to llvm-gcc-4.2 if it's clang (the least favorable solution)

Adding configure.compiler llvm-gcc-4.2 doesn't help.

  • add -std=c89 to configure.cflags if compiling with clang

Adding configure.cflags-append "-std=gnu89" doesn't help either.

  • patch the code to drop the inline from the function declaration (imho the best solution here)

I don't have the skills for this...

Also, if it turns out the problem was caused by this you might want to report it back to upstream for assuming to be compiled against the GNU 89 standard without actually specifying a standard.

I'll look into that. I'm not sure if OSX is considered a supported platform for ISC DHCP.

Changed 12 years ago by stefan.van.der.eijk@…

Attachment: Portfile.4.1-ESV-R4.diff added

comment:5 Changed 12 years ago by stefan.van.der.eijk@…

Managed to build 4.1-ESV-R4. See: Portfile.4.1-ESV-R4.diff

Can the package be updated with this patch?

comment:6 Changed 12 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

Commited in r91703, r91704 and r91705 with the following changes:

  • removed no longer needed site.conf file
  • deleted default configurations `$prefix/etc/{dhcpd,dhclient}.conf
  • added modeline to the Portfile and formatted whitespace
  • converted checksums to the new recommended types sha256 and rmd160

Thanks for your work.

comment:7 Changed 12 years ago by neverpanic (Clemens Lang)

Keywords: clang removed
Note: See TracTickets for help on using tickets.