Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#33544 closed enhancement (fixed)

Change default gfortran/gcj dependency from gcc44 to gcc45

Reported by: jmroot (Joshua Root) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: Tom.Schoonjans@…, adfernandes (Andrew Fernandes), danieljprice (Daniel Price), dbevans (David B. Evans), dmeliza@…, eborisch (Eric A. Borisch), howarth@…, jameskyle@…, jochen@…, cjones051073 (Chris Jones), julians37@…, jyrkiwahlstedt, kevin@…, kjell.konis@…, mattiafrancescomoro@…, MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), michaelld (Michael Dickens), mkae (Marko Käning), mamoll (Mark Moll), mnick@…, mww@…, pandagoat@…, pkgw (Peter Williams), pixilla (Bradley Giesbrecht), skymoo (Adam Mercer), ryandesign (Ryan Schmidt), jdswinbank (John Swinbank), tenomoto (Takeshi Enomoto), Russell-Jones-OxPhys (Russell Jones)
Port:

Description

This is a kind of sequel to #20103. If this change isn't appropriate for your port, please speak up. If there are any problems with gcc45 that need to be worked out before this can go ahead, please mention those too.

Attachments (2)

gcc44-ports.txt (2.3 KB) - added by jmroot (Joshua Root) 9 years ago.
list of affected ports
gcc45.diff (48.9 KB) - added by jmroot (Joshua Root) 9 years ago.

Download all attachments as: .zip

Change History (16)

Changed 9 years ago by jmroot (Joshua Root)

Attachment: gcc44-ports.txt added

list of affected ports

comment:1 Changed 9 years ago by skymoo (Adam Mercer)

Any reason not to go to gcc46?

comment:2 Changed 9 years ago by ryandesign (Ryan Schmidt)

pure-gen already had gcc43 gcc44 gcc45 variants and I've been using the gcc45 variant so in r90574 I made that the default. In r90577 I added a gcc46 variant.

cdf didn't have gcc variants; it always used gcc44. In r90575 I added gcc44 gcc45 gcc46 variants and left the default at gcc44. Ideally I'd wait until after I've updated cdf to the next version before changing its gcc default.

comment:3 in reply to:  1 ; Changed 9 years ago by jmroot (Joshua Root)

It's best if this happens all at once, as otherwise new installs will tend to get multiple gcc versions during the transition.

Replying to ram@…:

Any reason not to go to gcc46?

It's apparently missing gcj (#30357), and I get the general impression that there are more tickets about current problems for 46 than 45 (this might not be true).

comment:4 in reply to:  3 Changed 9 years ago by skymoo (Adam Mercer)

Replying to jmr@…:

It's apparently missing gcj (#30357), and I get the general impression that there are more tickets about current problems for 46 than 45 (this might not be true).

That would be a good reason. No objections from me.

comment:5 Changed 9 years ago by pkgw (Peter Williams)

The miriad port already uses gcc45 as its default variant. I needed to push an update anyway, so I've done that in #33567 and also added a gcc46 variant as an option.

Changed 9 years ago by jmroot (Joshua Root)

Attachment: gcc45.diff added

comment:6 Changed 9 years ago by jmroot (Joshua Root)

I've attached a patch that implements this change.

comment:7 in reply to:  2 ; Changed 9 years ago by jmroot (Joshua Root)

Replying to ryandesign@…:

Ideally I'd wait until after I've updated cdf to the next version before changing its gcc default.

Why? Changing the default variant doesn't affect anyone who already has the port installed. The only other reason I can think of to wait until the next version to change it is if gcc45 doesn't work properly with the current version, in which case the variant should be disabled altogether for now. Or is there some other issue I'm not seeing?

comment:8 Changed 9 years ago by kjell.konis@…

I just modified my R port update (#33512) so that gcc45 is the default compiler.

comment:9 Changed 9 years ago by mamoll (Mark Moll)

I did the same for arpack in r90710. My other affected port, hdf5-18, is actually not affected: by default fortran bindings are not enabled.

comment:10 Changed 9 years ago by jmroot (Joshua Root)

Again, it's best if this happens all at once. You needn't do anything if the patch is OK for your ports. I'll apply it soon.

comment:11 Changed 9 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

comment:12 in reply to:  7 Changed 9 years ago by ryandesign (Ryan Schmidt)

Replying to jmr@…:

Replying to ryandesign@…:

Ideally I'd wait until after I've updated cdf to the next version before changing its gcc default.

Why? Changing the default variant doesn't affect anyone who already has the port installed.

Yes, it does. Users who had cdf installed before r90575 will have it installed with gcc44 but will not have any variant set. When those users now upgrade to cdf 3.4.0, they will be switched to the gcc45 variant, which might not be what they wanted. Had we waited with switching the default variant to gcc45 until after the port was updated to 3.4.0, the upgrade would have occurred with gcc44, and the variant would then have been set, and would then have been kept through any future upgrades, regardless of what we change the default to later; the user would thus have been in control of the gcc version.

comment:13 Changed 9 years ago by Russell-Jones-OxPhys (Russell Jones)

gcc45 isn't building on 10.7.3 for me. Anyone else having this problem? I'll look into it further today and submit a ticket if I have time.

comment:14 in reply to:  13 Changed 9 years ago by ryandesign (Ryan Schmidt)

Cc: russell.jones@… added

Replying to russell.jones@…:

gcc45 isn't building on 10.7.3 for me. Anyone else having this problem? I'll look into it further today and submit a ticket if I have time.

It's off-topic for this ticket, which is closed and resolved. File a new ticket or discuss on the mailing list.

Note: See TracTickets for help on using tickets.