libpixman missing build dependency on pkgconfig

[mf2k (Frank Schima)]

Sorry I don't have a log because I needed to get it built, but I believe libpixman is missing a build dependency on pkgconfig. Basically it failed in configure without it and built fine when I installed in manually.

This in on Mac OS X 10.7.3 with Xcode 4.3.1.

[ryandesign (Ryan Carsten Schmidt)]

This is fallout from #32260 where we added the option to disable libpng support.

Currently libpixman has no dependencies. The goal of #32260 was to make it so that libpixman would not attempt to use a libpng that it found, because I wanted to avoid adding a dependency on libpng. libpng builds quickly and only depends on zlib which also builds quickly:

$ port rdeps libpng
The following ports are dependencies of libpng @1.4.9_0:
  zlib

But on principal, I don't want to add dependencies on software we don't need.

But now somehow we're using pkgconfig, which has a much larger list of dependencies, that I even more greatly do not want to add:

$ port rdeps pkgconfig
The following ports are dependencies of pkgconfig @0.26_1:
  glib2
    xz
      libiconv
        gperf
      gettext
        ncurses
          ncursesw
        expat
    zlib
    libffi
    perl5
      perl5.12
        gdbm

The problem seems not to be the patch itself, but that we're running autoreconf after applying it. libpixman-devel, which already has the patch built-in, does not complain about pkgconfig.

[ryandesign (Ryan Carsten Schmidt)]

r90887