Opened 9 years ago

Closed 4 years ago

#33932 closed defect (wontfix)

Erroneous "Missing subversion property on Portfile" error

Reported by: ryandesign (Ryan Schmidt) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: base Version: 2.0.99
Keywords: haspatch Cc:
Port:

Description

$ port lint zlib
--->  Verifying Portfile for zlib
Error: Missing subversion property on Portfile, please execute: svn ps svn:keywords Id Portfile
Error: Missing subversion property on Portfile, please execute: svn ps svn:eol-style native Portfile
--->  2 errors and 0 warnings found.

This is false:

$ svn pl -v $(port file zlib)
Properties on '/Users/rschmidt/macports/dports/archivers/zlib/Portfile':
  svn:keywords
    Id
  svn:eol-style
    native

Attachments (1)

portlint.tcl.diff (1.1 KB) - added by ryandesign (Ryan Schmidt) 9 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 9 years ago by ryandesign (Ryan Schmidt)

The debug output reveals the problem:

DEBUG: Property svn:keywords is "svn: warning: Can't open file '/Users/rschmidt/.macports/opt/local/var/macports/build/_Users_rschmidt_macports_dports_archivers_zlib/zlib/work/.home/.subversion/servers': Permission denied
Id", should be "Id"
Error: Missing subversion property on Portfile, please execute: svn ps svn:keywords Id Portfile

Also:

$ sudo port lint zlib
--->  Verifying Portfile for zlib
--->  0 errors and 0 warnings found.

So we should just ignore the error output from the svn command.

Changed 9 years ago by ryandesign (Ryan Schmidt)

Attachment: portlint.tcl.diff added

comment:2 Changed 9 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added

The attached patch would do this. The problem is this would eliminate possibly helpful error output in the case that svn returns with a nonzero exit code. I don't know if there's a way to get [exec] to put the stdout and stderr in separate variables; that would be helpful.

comment:3 Changed 4 years ago by raimue (Rainer Müller)

Resolution: wontfix
Status: newclosed

No longer relevant after we switched to Git.

Note: See TracTickets for help on using tickets.