Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#34203 closed submission (fixed)

sstp-client 1.0.7 submission

Reported by: enaess (Eivind Næss) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.0.4
Keywords: net, vpn, remote access Cc:
Port: sstp-client

Description

I've attached a port file for the sstp-client package on sourceforge.net. https://sourceforge.net/projects/sstp-client/

Best Regards,

  • Eivind

Attachments (1)

Portfile (1.3 KB) - added by enaess (Eivind Næss) 12 years ago.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by enaess (Eivind Næss)

Attachment: Portfile added

comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Milestone: MacPorts 2.1.0

comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks.

comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Added in r92427 with these changes:

  • added standard modeline and adjusted whitespace of portfile
  • moved description to long_description and added shorter description
  • fixed license
  • rewrote master_sites to avoid redirects
  • removed lines "extract.suffix .tar.gz", "worksrcdir ${name}-${version}", "use_configure yes"; those are all the defaults so they're unnecessary to specify
  • also removed the livecheck lines, since the default livecheck seems to work fine
  • added configure arg --disable-silent-rules so we get more useful information in the debug log

May I inquire as to the reason why you put the line "universal_variant no"? The port appears to build universal correctly without that line. Let me know why the universal variant should stay disabled so that I can add a comment to the portfile to explain it.

comment:4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Now that I think about it, same question about the line "destroot.args PREFIX=${prefix}" which I don't think is needed either.

comment:5 in reply to:  4 Changed 12 years ago by enaess (Eivind Næss)

Thank you so much for cleaning up this Portfile, I started with an existing portfile from a different port so if some stuff might be wrong, then please have it corrected. 1) universal_variant = no, probably a cut and paste bug. You can set it to yes. 2) If you are able to build it without specifying the destroot.args PREFIX=${prefix}, by all means remove it.

comment:6 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Ok, r92448.

Note: See TracTickets for help on using tickets.