Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#34543 closed update (fixed)

qrupdate: update to 1.1.2

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.1
Keywords: haspatch Cc: rjfergus@…
Port: qrupdate

Description

Here's a patch to update qrupdate to 1.1.2. It fails to build just like 1.1.1 so it still needs some changes (see #25662) before it can be committed.

This patch also drops the legacy "accelerate" variant that was deprecated 18 months ago, and changes the old "no_atlas" variant to an "atlas" variant.

Attachments (1)

qrupdate-1.1.2.diff (3.1 KB) - added by ryandesign (Ryan Carsten Schmidt) 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: qrupdate-1.1.2.diff added

comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

The reason it failed to build was that I forgot to actually reverse the meaning of the new atlas variant. I do not have atlas installed, so I was turning off the atlas variant, but in my broken patch that actually made it try to use atlas, thus of course the symbols weren't defined because the library wasn't there at all.

Fixed and committed in r93488. Builds fine without atlas now. With atlas is probably still the same as #25662.

comment:2 in reply to:  description Changed 12 years ago by rjfergus@…

Resolution: fixed
Status: closedreopened

Replying to ryandesign@…:

Here's a patch to update qrupdate to 1.1.2. It fails to build just like 1.1.1 so it still needs some changes (see #25662) before it can be committed.

This patch also drops the legacy "accelerate" variant that was deprecated 18 months ago, and changes the old "no_atlas" variant to an "atlas" variant.

Hi,

This patch fails when I try to install it with "4 out of 4 hunks FAILED" reported. I use "sudo patch -p0 < qrupdate-1.1.2.diff". Any help is appreciated.

Robert

comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: rjfergus@… added
Resolution: fixed
Status: reopenedclosed

I already fixed this 6 days ago. You don't need to apply the patch manually; as I said above the patch was wrong anyway. You just "sudo port selfupdate", "sudo port clean qrupdate", and try again.

comment:4 in reply to:  3 Changed 12 years ago by rjfergus@…

Replying to ryandesign@…:

I already fixed this 6 days ago. You don't need to apply the patch manually; as I said above the patch was wrong anyway. You just "sudo port selfupdate", "sudo port clean qrupdate", and try again.

Hi,

Thanks for the swift reply and sorry that I seem so confused. So if I understand, I run "selfupdate" then "clean qrupdate" then "upgrade outdated"?

Robert

Note: See TracTickets for help on using tickets.