#34680 closed defect (fixed)
port atlas - remove ui_warn command from top level, add maintainer
| Reported by: | anddam (Andrea D'Amore) | Owned by: | jameskyle@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.1 |
| Keywords: | Cc: | Veence (Vincent) | |
| Port: | atlas |
Description (last modified by anddam (Andrea D'Amore))
atlas has an ui_warn at portfile root level at line 245, this leads to the warning being printed whenever the portfile is read and parsed, like dependency checking for atlas' dependents or even a simple port lint atlas.
Please move into a more appropriate block, post-configure seems a good candidate.
At the same time I suggest vince is marked as maintainer since most commits in last 18 months are his.
Change History (8)
comment:1 Changed 12 years ago by anddam (Andrea D'Amore)
| Description: | modified (diff) |
|---|
comment:2 follow-up: 5 Changed 12 years ago by Veence (Vincent)
comment:3 Changed 12 years ago by Veence (Vincent)
PS: I have moved the message in the "pre-fetch" phase, because I want the user to be warned early of this limitation (so that he may abort and opt for clang, for example).
comment:4 Changed 12 years ago by Veence (Vincent)
I had made a typo 'pre-fecth' instead of pre-fetch. Corrected in r93769.
comment:5 Changed 12 years ago by anddam (Andrea D'Amore)
Replying to vince@…:
Should be fixed in r93768.
You should have waited before committing the patch. I've edited commit message to reference this ticket and #25662.
Replying to vince@…:
I have no set myself maintainer, I think it must follow a collegial decision.
No, you just need to be willing to maintain the package and follow the abandonment policy.
Replying to vince@…:
BTW, I’m unable to contact James. His direct mail bounces, and I suspect the @macports.org does too, even if we don’t get any error message.
I'm trying to contact him as well, if the email bounces I suggest you just take maintainership, there's no point in having a maintainer if he's not getting messages.
Since this ticket is about editing maintainer I suggest to keep it open and update it later.
comment:6 Changed 12 years ago by anddam (Andrea D'Amore)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Added vince as maintainer in r93931, maintainer timeout. Ticket closed.
comment:7 Changed 12 years ago by jameskyle@…
@Vince
More than happy to pass the maintainership to you. As has been noticed, my attention has been elsewhere for a while now.
comment:8 Changed 12 years ago by Veence (Vincent)
@James
Nice to hear from you James. Ok, I’ll take over then. Have fun!
Should be fixed in r93768. I have no set myself maintainer, I think it must follow a collegial decision. BTW, I’m unable to contact James. His direct mail bounces, and I suspect the @macports.org does too, even if we don’t get any error message.