Opened 6 years ago

Closed 4 years ago

#35339 closed update (fixed)

zorba: Update to 3.0

Reported by: cezar.andrei@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: ryandesign (Ryan Schmidt), ak.ml@…
Port: zorba

Description

This is an update to zorba port to upgrade to release 2.5.

Attached are the patch to the Portfile and updated patch files.

Attachments (8)

Portfile (2.4 KB) - added by cezar.andrei@… 6 years ago.
New Portfile for zorba 2.5
patch-docdir.diff (4.5 KB) - added by cezar.andrei@… 6 years ago.
patch1 in files dir
patch-src-types-schema-SchemaValidatorFilter.h.diff (497 bytes) - added by cezar.andrei@… 6 years ago.
patch2 in files dir
patch-test-rbkt-testdriver_mt.cpp.diff (6.7 KB) - added by cezar.andrei@… 6 years ago.
patch3 in files dir
zorba.2.diff (1.3 KB) - added by cezar.andrei@… 6 years ago.
Diff to zorba 2.2 Portfile take#2 works fine with Xcode 4.4 - no clang-3.1 dependency
Portfile-zorba2.7 (3.4 KB) - added by cezar.andrei@… 6 years ago.
Portfile for Zorba 2.7
Portfile-zorba-2.8.0 (3.5 KB) - added by cezar.andrei@… 6 years ago.
Zorba 2.8 portfile
zorba.diff (2.6 KB) - added by cezar.andrei@… 6 years ago.
diff to upgrade to Zorba 2.8

Download all attachments as: .zip

Change History (19)

Changed 6 years ago by cezar.andrei@…

Attachment: Portfile added

New Portfile for zorba 2.5

Changed 6 years ago by cezar.andrei@…

Attachment: patch-docdir.diff added

patch1 in files dir

Changed 6 years ago by cezar.andrei@…

patch2 in files dir

Changed 6 years ago by cezar.andrei@…

patch3 in files dir

comment:1 Changed 6 years ago by mf2k (Frank Schima)

Keywords: haspatch added; zorba removed
Milestone: MacPorts Future
Version: 2.1.1

Please do not set the Milestone field.

comment:2 Changed 6 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added
Summary: Update zorba to 2.5 releasezorba: Update to 2.5 release

Thanks!

Some observations:

  • "distfiles ${distname}.gz" seems wrong; you probably want to set "extract.suffix .gz" instead.
  • Why is the MacPorts clang 3.1 compiler required? Is the version of clang in Xcode 4.2 and up not sufficient? what about the llvm-gcc-4.2 or gcc-4.2 compilers in earlier Xcode versions? We'd rather not add a heavy dependency like a compiler unless it's absolutely necessary.

comment:3 in reply to:  2 Changed 6 years ago by cezar.andrei@…

Replying to ryandesign@…:

  • "distfiles ${distname}.gz" seems wrong; you probably want to set "extract.suffix .gz" instead.

You're probably right, I didn't know about extract.suffix. The files I attached are tested.

  • Why is the MacPorts clang 3.1 compiler required? Is the version of clang in Xcode 4.2 and up not sufficient? what about the llvm-gcc-4.2 or gcc-4.2 compilers in earlier Xcode versions? We'd rather not add a heavy dependency like a compiler unless it's absolutely necessary.

With clang-2.9 the default from Xcode 4.2 was giving me errors like the following:

error: expected the class name after '~' to name the enclosing class 

After moving to clang-3.1 there were no errors. I didn't try it out with any others, it might just work. I just updated to Xcode 4.4, I'll give it another try without clang-3.1 dependency.

Changed 6 years ago by cezar.andrei@…

Attachment: zorba.2.diff added

Diff to zorba 2.2 Portfile take#2 works fine with Xcode 4.4 - no clang-3.1 dependency

comment:4 Changed 6 years ago by cezar.andrei@…

I just uploaded the last patch to Portfile, this zorba.2.diff :

  • uses extract.suffix .gz
  • doesn't have the clang-3.1 dependency
  • works fine with clang 4.0 from Xcode 4.4

comment:5 Changed 6 years ago by cezar.andrei@…

Zorba 2.7 is out. I'll add the new Portfile-2.7.

Changed 6 years ago by cezar.andrei@…

Attachment: Portfile-zorba2.7 added

Portfile for Zorba 2.7

comment:6 Changed 6 years ago by ak.ml@…

Cc: ak.ml@… added

Cc Me!

Changed 6 years ago by cezar.andrei@…

Attachment: Portfile-zorba-2.8.0 added

Zorba 2.8 portfile

comment:7 Changed 6 years ago by cezar.andrei@…

Zorba 2.8 is close to release, attached is the portfile for the upgrade.

comment:8 Changed 6 years ago by cezar.andrei@…

Update for Zorba 2.8.0 upcoming release. Please include in Macports.

comment:9 Changed 6 years ago by ryandesign (Ryan Schmidt)

We would prefer unified diffs (like you had attached for the 2.5 update) instead of complete portfiles (like you attached for the 2.7 and 2.8 updates).

There are several changes I would make to the 2.8 Portfile, including removing commented-out lines that aren't needed, not hardcoding the version in the distfiles and checksums, ordering the dependencies alphabetically, and using spaces instead of tabs to match the rest of the portfile.

If old versions of clang cannot build zorba they should be blacklisted using the compiler_blacklist_versions portgroup.

I tried the 2.8 portfile and the checksums didn't match. I assume the distfile changed after you put the checksums into the portfile. I see the distfile is being fetched from http://my.zorba-xquery.com/tmp/ instead of the previous launchpad URL. The launchpad URL is still the one listed on the zorba web site. The zorba web site lists 2.7 as the latest version. I think we should use the latest released version, not a prerelease. Also I was confused why a dependency on the libarchive port is added (which means you want to use libarchive) but also a configure arg "-DZORBA_SUPPRESS_LIBARCHIVE=YES" is added (which suggests to me you don't want to use libarchive).

I went to the 2.7 portfile you attached previously. It too is set to download from the above temporary URL. The checksums match, but the file it downloads is different from the file of the same name offered at launchpad in the following ways:

Only in zorba-2.7.0-launchpad: .bzrignoreOnly in zorba-2.7.0-launchpad/src/compiler/codegen: plan_visitor.cpp.~1~
Only in zorba-2.7.0-launchpad/src/diagnostics: diagnostic_en.xml.~1~
Only in zorba-2.7.0-tmp/src/runtime/core: pregenerated
Only in zorba-2.7.0-launchpad/src/runtime/errors_and_diagnostics: errors_and_diagnostics_impl.cpp.~1~
Only in zorba-2.7.0-tmp/src/runtime/eval: pregenerated
Only in zorba-2.7.0-launchpad/src/runtime/json: jsoniq_functions_impl.cpp.~1~
Only in zorba-2.7.0-tmp/src/runtime: rest
Only in zorba-2.7.0-tmp/src/runtime/scripting: pregenerated
Only in zorba-2.7.0-tmp/src/runtime/spec: reflection
Only in zorba-2.7.0-tmp/src/runtime/spec: scripting
Only in zorba-2.7.0-launchpad/src/store/naive: node_items.cpp.~1~
Only in zorba-2.7.0-launchpad/src/store/naive: pul_primitives.cpp.~1~
Only in zorba-2.7.0-tmp/test: coverity
Only in zorba-2.7.0-tmp/test/rbkt/ExpQueryResults/zorba/collections: delete_nodes_first
Only in zorba-2.7.0-tmp/test/rbkt/ExpQueryResults/zorba/collections: delete_nodes_last
Only in zorba-2.7.0-tmp/test/rbkt/Queries/zorba/utf-8: xml_files

I don't know the significance of these differences. I wanted to switch to launchpad as the download URL, but launchpad does not have the modules file that the port downloads. Why is that file only available on your site in a temporary directory? There is a modules file at launchpad for zorba 2.6.

This is all very confusing. What should we do?

Changed 6 years ago by cezar.andrei@…

Attachment: zorba.diff added

diff to upgrade to Zorba 2.8

comment:10 Changed 6 years ago by cezar.andrei@…

I attached the Portfile diff to upgrade to the now released Zorba 2.8. It also contains fixes for Ryan's comments.

Uses 2.8 release files from https://launchpad.net/zorba .

comment:11 Changed 4 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed
Summary: zorba: Update to 2.5 releasezorba: Update to 3.0

Updated zorba to 3.0 in r124409.

Note: See TracTickets for help on using tickets.