Changes between Initial Version and Version 1 of Ticket #37352

Timestamp:

Dec 20, 2012, 12:58:08 PM (11 years ago)

Author:

ryandesign (Ryan Carsten Schmidt)

Comment:

Thank you but this patch has a few problems:

• it mixes whitespace and functional changes
• it introduces your name into the maintainers line, which should only contain (obfuscated) email addresses
• it changes "OS X" (which is the correct name of the OS) to "Mac OSX"
• it adds a "dist_subdir" line which is unnecessary unless a stealth update has occurred, which I assume it hasn't since you haven't changed the checksums
• it removes the license line
• it adds "--prefix=${prefix}" to configure.args which is unnecessary because MacPorts automatically puts that into configure.pre_args
• it changes master_sites from the simple and recommended googlecode to a more verbose URL
• it adds an unnecessary "# end of file." comment