Opened 11 years ago

Closed 11 years ago

#37638 closed defect (fixed)

apple-gcc42: variant gpl3 has broken SSE intrinsics header

Reported by: internetzel Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: haspatch Cc:
Port: apple-gcc42

Description

The patch from 4.2.1 to 4.2.4 breaks the SSE intrinsics header, emmintrin.h .

Attachments (3)

emmintrin.patch (1.8 KB) - added by internetzel 11 years ago.
This patch patches the patchfile, distfiles/apple-gcc42/gcc-4.2.1-4.2.4.patch .
gcc-4.2.1-4.2.4.patch (18.1 MB) - added by tobias.netzel@… 11 years ago.
updated patchfile
emmintrin.2.patch (1.1 KB) - added by tobias.netzel@… 11 years ago.
patch to be applied after having applied the previous buggy patch

Change History (8)

Changed 11 years ago by internetzel

Attachment: emmintrin.patch added

This patch patches the patchfile, distfiles/apple-gcc42/gcc-4.2.1-4.2.4.patch .

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: jeremyhu@… removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to jeremyhu@…
Port: apple-gcc42 added; apple-gcc42+gpl3 removed

comment:2 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

We can't patch the patch (as it might be mirrored). We should have a second followup patch instead.

Changed 11 years ago by tobias.netzel@…

Attachment: gcc-4.2.1-4.2.4.patch added

updated patchfile

Changed 11 years ago by tobias.netzel@…

Attachment: emmintrin.2.patch added

patch to be applied after having applied the previous buggy patch

comment:3 Changed 11 years ago by tobias.netzel@…

So one can't check in a simple patch into the macports repository to fix this bug but instead has to add a second patch to the portfile?
That sounds strange - but in that case I suggest to change from the old buggy patch to a new fixed one (the attached gcc-4.2.1-4.2.4.patch) - with a different file name if necessary.

If that's impossible for any reason the attached emmintrin.2.patch needs to be added to the portfile.

Last edited 11 years ago by tobias.netzel@… (previous) (diff)

comment:4 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

The gcc-4.2.1-4.2.4.patch patch is already mirrored in distfiles. It's not in dports. Thus we can't update it and must keep mirroring the old version. It would be better to just include the single emmintrin.2.patch to cleanup the problem of the existing patch. Thanks.

comment:5 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.