Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#38117 closed defect (fixed)

active_variants: allow multiple port names to be specified

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: Cc: neverpanic (Clemens Lang), cooljeanius (Eric Gallager), michaelld (Michael Dickens)
Port:

Description

Currently, I can use e.g.:

require_active_variants pango x11

to require that the pango port be installed with the +x11 variant. However it should be permitted for users to use the pango-devel port instead. We need a way to tell require_active_variants of alternate port names. Perhaps this syntax should be supported:

require_active_variants {pango pango-devel} x11

Attachments (1)

a_v_1.1_add-path.diff (1.7 KB) - added by michaelld (Michael Dickens) 11 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 11 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Even nicer might be if we could just use normal dependency specifiers, e.g.:

require_active_variants path:lib/pkgconfig/pango.pc:pango x11

comment:3 Changed 11 years ago by cooljeanius (Eric Gallager)

This would make sense considering you can already specify multiple variants with this. If you can specify multiple variants with require_active_variants, I would think it would be theoretically pretty easy to take the code for specifying multiple variants and turn it into code for specifying multiple ports.

comment:4 Changed 11 years ago by neverpanic (Clemens Lang)

Patches welcome, in this case :)

I think it might actually be easier to move this into base at this point, because base probably has an easy way to resolve path-style (and other) dependencies.

comment:5 Changed 11 years ago by neverpanic (Clemens Lang)

Owner: changed from macports-tickets@… to cal@…
Status: newassigned

comment:6 Changed 11 years ago by michaelld (Michael Dickens)

Cc: michaelld@… added

Cc Me!

comment:7 Changed 11 years ago by michaelld (Michael Dickens)

I posted about this issue on the mp-dev list. I've attached the patch here, too; it implements the "path:...:port" version, just like a dependency.

Changed 11 years ago by michaelld (Michael Dickens)

Attachment: a_v_1.1_add-path.diff added

comment:8 Changed 11 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: assignedclosed

comment:9 Changed 11 years ago by neverpanic (Clemens Lang)

I've fixed the ports that were incorrectly limiting the dependencies to a single port due to the active_variants checks in

Note: See TracTickets for help on using tickets.