Opened 5 years ago

Closed 5 years ago

#38212 closed enhancement (fixed)

openssl: cleanup

Reported by: ryandesign (Ryan Schmidt) Owned by: mww@…
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: haspatch Cc:
Port: openssl

Description

Here's a patch that simplifies the openssl portfile a little.

Instead of setting configure.cmd to ./config and then in all cases replacing it with ./Configure later, just set it to ./Configure in the first place.

And there's no need to remove --disable-dependency-tracking from configure.args because there is no circumstance in which it would be in there to begin with.

Attachments (1)

openssl-cleanup.diff (885 bytes) - added by ryandesign (Ryan Schmidt) 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by ryandesign (Ryan Schmidt)

comment:1 follow-up: Changed 5 years ago by cooljeanius (Eric Gallager)

And there's no need to remove --disable-dependency-tracking from configure.args because there is no circumstance in which it would be in there to begin with.

Sometimes it randomly ends up in my configure.args even when it's not supposed to be there.

comment:2 in reply to: ↑ 1 Changed 5 years ago by larryv (Lawrence Velázquez)

Replying to egall@…:

And there's no need to remove --disable-dependency-tracking from configure.args because there is no circumstance in which it would be in there to begin with.

Sometimes it randomly ends up in my configure.args even when it's not supposed to be there.

It is appended to configure.pre_args when building +universal.

comment:3 Changed 5 years ago by ryandesign (Ryan Schmidt)

  • Resolution set to fixed
  • Status changed from new to closed

So the correct solution, which the port already does, is to remove it from configure.universal_args. It does not need to be removed from configure.args because it is never in configure.args.

r103623

Note: See TracTickets for help on using tickets.