Opened 10 years ago

Closed 6 years ago

#38264 closed submission (fixed)

New port: gcab

Reported by: cooljeanius (Eric Gallager) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: dbevans (David B. Evans)
Port: gcab

Description

gcab is a program to create Microsoft cabinet (.cab) archives. It's a dependency for building msitools, which I'm working on next.

Attachments (3)

Portfile (1.8 KB) - added by cooljeanius (Eric Gallager) 10 years ago.
Portfile for gcab
Portfile.2 (2.1 KB) - added by cooljeanius (Eric Gallager) 10 years ago.
New portfile
Portfile.diff (1.8 KB) - added by cooljeanius (Eric Gallager) 10 years ago.
diff between old portfile and new one

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by cooljeanius (Eric Gallager)

Attachment: Portfile added

Portfile for gcab

comment:1 Changed 10 years ago by ryandesign (Ryan Schmidt)

  • Regarding master_sites, you probably want "gnome:sources/${name}/${branch}/"
  • Is the gettext library really not used?
  • The glib2 dependency should be written so that glib2-devel could satisfy it; see any other port that depends on glib2 for an example.
  • There should be more than one checksum listed.

Changed 10 years ago by cooljeanius (Eric Gallager)

Attachment: Portfile.2 added

New portfile

Changed 10 years ago by cooljeanius (Eric Gallager)

Attachment: Portfile.diff added

diff between old portfile and new one

comment:2 in reply to:  1 Changed 10 years ago by cooljeanius (Eric Gallager)

Replying to ryandesign@…:

  • Regarding master_sites, you probably want "gnome:sources/${name}/${branch}/"

OK, that works (once I add the branch variable in the first place, that is), thanks. Changed.

  • Is the gettext library really not used?

I had originally only included gettext as a build dependency because I had used gettextize at one point, but after checking "port -q contents gcab | xargs file | grep Mach-O | cut -d\: -f1 | cut -d\ -f1 | uniq | xargs otool -L | grep version | grep /opt/local | cut -d\ -f1 | xargs port -q provides | cut -d\: -f2 | sort | uniq ", it turns out it is actually a library dependency, along with libffi and libiconv, so I moved gettext to the library dependencies, and added libffi and libiconv to the library dependencies, as well.

  • The glib2 dependency should be written so that glib2-devel could satisfy it; see any other port that depends on glib2 for an example.

Fixed.

  • There should be more than one checksum listed.

I had originally only included the sha256 one because it had come pre-calculated in a file named "gcab-0.4.sha256sum"; I've calculated the rest of them now and added them to the portfile now, too, though.

comment:3 Changed 10 years ago by mf2k (Frank Schima)

Version: 2.1.3

The md5 and "sha" checksums are not necessary and obsolete. Just use rmd160 and sha256 as per the guidelines.

comment:4 in reply to:  3 Changed 10 years ago by cooljeanius (Eric Gallager)

Replying to macsforever2000@…:

The md5 and "sha" checksums are not necessary and obsolete.

OK, feel free to remove those when committing this.

comment:5 Changed 9 years ago by cooljeanius (Eric Gallager)

comment:6 Changed 6 years ago by ryandesign (Ryan Schmidt)

Cc: devans@… added
Resolution: fixed
Status: newclosed

A gcab port was added in r133834.

Note: See TracTickets for help on using tickets.