Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#38267 closed defect (fixed)

v8 @3.17.6 +universal needs its configure.universal_args nuked

Reported by: cooljeanius (Eric Gallager) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: haspatch Cc: frodwith@…, neverpanic (Clemens Lang)
Port: v8

Description

Its configure script doesn't recognize the --disable-dependency-tracking flag.

Attachments (1)

Portfile.diff (517 bytes) - added by cooljeanius (Eric Gallager) 11 years ago.
diff to apply to v8's portfile

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by cooljeanius (Eric Gallager)

Attachment: Portfile.diff added

diff to apply to v8's portfile

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Please just write:

configure.universal_args-delete --disable-dependency-tracking

like other ports do. It doesn't need to go inside the universal variant; I don't think any other ports do that.

comment:2 Changed 11 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

Fixed in r103654. What's the benefit of this flag anyway? Should we remove it in base?

comment:3 in reply to:  2 ; Changed 11 years ago by larryv (Lawrence Velázquez)

comment:4 in reply to:  3 ; Changed 11 years ago by cooljeanius (Eric Gallager)

Replying to larryv@…:

Replying to cal@…:

What's the benefit of this flag anyway? Should we remove it in base?

http://www.gnu.org/software/automake/manual/html_node/Dependency-Tracking.html

So in other words we could remove it from everything that doesn't use automake?

comment:5 in reply to:  4 Changed 11 years ago by larryv (Lawrence Velázquez)

Replying to egall@…:

So in other words we could remove it from everything that doesn't use automake?

No. The flag is necessary for universal builds because automatic dependency generation cannot be done when targeting multiple architectures. I presume that the configure scripts that don’t accept the flag have dependency generation disabled by default.

In my experience, most configure scripts that don’t accept the flag just ignore it. Unless the flag actually causes problems with configure, I don’t see why we should bother dealing with it.

Version 0, edited 11 years ago by larryv (Lawrence Velázquez) (next)
Note: See TracTickets for help on using tickets.