Opened 11 years ago

Closed 4 years ago

#38525 closed defect (fixed)

poppler @0.22.2: fix conflict between docs and universal variant

Reported by: cooljeanius (Eric Gallager) Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: Cc: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Port: poppler

Description

Poppler's +docs variant was originally added in r44415; but then it was made to conflict with the universal variant in r50531 when the port switched to the muniversal portgroup. There was no explanation why this conflict was introduced, although I can assume it was because the docs probably didn't merge properly or something with the muniversal portgroup. Still, I'd like it if this conflict were somehow resolved, because as it is, anything that depends on poppler, even indirectly, will also have to have its docs and universal variants conflict with one another, too.

Change History (8)

comment:1 in reply to:  description ; Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to egall@…:

anything that depends on poppler, even indirectly, will also have to have its docs and universal variants conflict with one another, too.

....why?

comment:2 in reply to:  1 Changed 11 years ago by cooljeanius (Eric Gallager)

Replying to ryandesign@…:

Replying to egall@…:

anything that depends on poppler, even indirectly, will also have to have its docs and universal variants conflict with one another, too.

....why?

Say I'm writing a port with both a +docs variant and a +universal variant. Then I go and try to install it with both of those variants. The install will error out on poppler because the +docs variant and the +universal variant will get propagated to it as well, so they'll be evaluated for poppler, causing the install to error out there.

comment:3 Changed 11 years ago by cooljeanius (Eric Gallager)

This can be solved by simply reworking the +docs variant as follows:

variant docs description {Build gtk-doc documentation} {
    PortGroup              archcheck 1.0
    depends_build-append   port:gtk-doc
    depends_skip_archcheck gtk-doc
    configure.args-delete  --disable-gtk-doc
    configure.args-append  --enable-gtk-doc
}

comment:4 Changed 11 years ago by larryv (Lawrence Velázquez)

Cc: devans@… removed
Owner: changed from macports-tickets@… to devans@…

comment:5 Changed 10 years ago by cooljeanius (Eric Gallager)

r115965 removed the docs variant entirely...

comment:6 Changed 10 years ago by dbevans (David B. Evans)

With the updated port there is no conflict and docs are installed (just not regenerated from scratch). I believe that --enable-gtk-doc variant is meant to be used when generating a new distribution file (upstream) and the docs need to be rebuilt to match updated code.

At any rate, try rebuilding poppler +universal and if there is a problem, attach the resulting build log so that it can be resolved. Works for me on ML but as I recall you're using SL.

comment:7 Changed 4 years ago by kencu (Ken)

comment:8 Changed 4 years ago by kencu (Ken)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.